From: Andrea Arcangeli <andrea@suse.de>
To: Thibaut Laurent <thibaut@celestix.com>
Cc: arjanv@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: [2.4.6] kernel BUG at softirq.c:206!
Date: Fri, 6 Jul 2001 14:43:11 +0200 [thread overview]
Message-ID: <20010706144311.J2425@athlon.random> (raw)
In-Reply-To: <20010704232816.B590@marvin.mahowi.de> <20010705162035.Q17051@athlon.random> <3B447B6D.C83E5FB9@redhat.com> <20010705164046.S17051@athlon.random> <20010705233200.7ead91d5.thibaut@celestix.com>
In-Reply-To: <20010705233200.7ead91d5.thibaut@celestix.com>; from thibaut@celestix.com on Thu, Jul 05, 2001 at 11:32:00PM +0800
On Thu, Jul 05, 2001 at 11:32:00PM +0800, Thibaut Laurent wrote:
> And the winner is... Andrea. Kudos to you, I've just applied these patches,
> recompiled and it seems to work fine.
can you apply this patch on top of the ksoftirqd patch and see if you
can trigger the BUG() again when based on pre2? (I want to make sure to
be as strict as mainline) Then if you apply the same patches on top of
pre3 the BUG() should go away.
--- 2.4.7pre2aa1/kernel/softirq.c.~1~ Thu Jul 5 17:13:47 2001
+++ 2.4.7pre2aa1/kernel/softirq.c Fri Jul 6 14:39:49 2001
@@ -173,7 +173,8 @@
if (!tasklet_trylock(t))
BUG();
if (!atomic_read(&t->count)) {
- clear_bit(TASKLET_STATE_SCHED, &t->state);
+ if (!test_and_clear_bit(TASKLET_STATE_SCHED, &t->state))
+ BUG();
t->func(t->data);
tasklet_unlock(t);
continue;
@@ -210,7 +211,8 @@
if (!tasklet_trylock(t))
BUG();
if (!atomic_read(&t->count)) {
- clear_bit(TASKLET_STATE_SCHED, &t->state);
+ if (!test_and_clear_bit(TASKLET_STATE_SCHED, &t->state))
+ BUG();
t->func(t->data);
tasklet_unlock(t);
continue;
Thanks!
Andrea
next prev parent reply other threads:[~2001-07-06 12:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-04 21:28 PROBLEM: [2.4.6] kernel BUG at softirq.c:206! Manfred H. Winter
2001-07-05 7:46 ` Mircea Damian
2001-07-05 11:18 ` Alan Cox
2001-07-05 12:10 ` Bob_Tracy
2001-07-05 13:04 ` Mircea Damian
2001-07-05 14:15 ` Manfred H. Winter
2001-07-05 10:52 ` Thibaut Laurent
2001-07-05 13:00 ` Mircea Damian
2001-07-05 11:04 ` Manfred H. Winter
2001-07-05 14:20 ` Andrea Arcangeli
2001-07-05 14:30 ` Alan Cox
2001-07-05 14:36 ` Arjan van de Ven
2001-07-05 14:40 ` Andrea Arcangeli
2001-07-05 15:32 ` Thibaut Laurent
2001-07-05 15:46 ` Arjan van de Ven
2001-07-05 15:56 ` Andrew Morton
2001-07-05 16:04 ` Alan Cox
2001-07-05 16:11 ` Andrew Morton
2001-07-05 16:15 ` Andrea Arcangeli
2001-07-05 22:40 ` Bob_Tracy
2001-07-06 3:42 ` Andrew Morton
2001-07-06 10:58 ` Manfred H. Winter
2001-07-06 12:43 ` Andrea Arcangeli [this message]
2001-07-06 14:18 ` Thibaut Laurent
2001-07-06 15:02 ` Andrea Arcangeli
2001-07-05 15:19 ` Manfred H. Winter
2001-07-05 12:14 Bob_Tracy
2001-07-05 13:42 ` Alan Cox
2001-07-05 14:02 ` Bob_Tracy
[not found] <E15I8gj-0002W7-00@the-village.bc.nu>
2001-07-05 13:59 ` Bob_Tracy
[not found] <3B4450DF.82EEC851@uow.edu.au>
2001-07-05 14:28 ` Manfred H. Winter
2001-07-05 15:23 ` Andrew Morton
2001-07-05 17:31 ` Manfred H. Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010706144311.J2425@athlon.random \
--to=andrea@suse.de \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thibaut@celestix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).