From: Andreas Dilger <adilger@turbolinux.com>
To: Chris Mason <mason@suse.com>
Cc: Alexander Viro <viro@math.psu.edu>,
Andreas Dilger <adilger@turbolinux.com>,
linux-kernel@vger.kernel.org, torvalds@transmeta.com,
lvm-devel@sistina.com
Subject: Re: [PATCH] LVM snapshot support for reiserfs and others
Date: Tue, 14 Aug 2001 14:25:33 -0600 (MDT) [thread overview]
Message-ID: <200108142025.f7EKPXKa027784@webber.adilger.int> (raw)
In-Reply-To: <992230000.997472946@tiny> "from Chris Mason at Aug 10, 2001 03:49:06 pm"
Chris writes:
> +static inline void write_super_lockfs(struct super_block *sb)
> +{
> + lock_super(sb);
> + if (sb->s_root) {
> + if (sb->s_dirt && sb->s_op && sb->s_op->write_super)
> + sb->s_op->write_super(sb);
> + if (sb->s_op && sb->s_op->write_super_lockfs)
> + sb->s_op->write_super_lockfs(sb);
> + }
> + unlock_super(sb);
> +}
Minor nit, could it be:
if (sb->s_root && sb->s_op) {
if (sb->s_dirt && sb->s_op->write_super)
sb->s_op->write_super(sb);
if (sb->s_op->write_super_lockfs)
sb->s_op->write_super_lockfs(sb);
}
I'm just going to do some testing...
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
next prev parent reply other threads:[~2001-08-14 20:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-09 18:35 [PATCH] LVM snapshot support for reiserfs and others Chris Mason
2001-08-09 19:22 ` Andreas Dilger
2001-08-09 20:34 ` Chris Mason
2001-08-09 20:58 ` Andreas Dilger
2001-08-09 22:20 ` Chris Mason
2001-08-09 22:24 ` Alexander Viro
2001-08-09 22:42 ` Chris Mason
2001-08-09 23:26 ` Alexander Viro
2001-08-09 23:50 ` Alexander Viro
2001-08-10 19:49 ` Chris Mason
2001-08-10 20:04 ` Andrew Morton
2001-08-14 20:25 ` Andreas Dilger [this message]
2001-08-22 4:06 ` Chris Mason
[not found] <no.id>
2001-08-10 22:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108142025.f7EKPXKa027784@webber.adilger.int \
--to=adilger@turbolinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvm-devel@sistina.com \
--cc=mason@suse.com \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).