From: Jens Axboe <axboe@suse.de>
To: Joe Thornber <thornber@btconnect.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: A possible direction for the next LVM driver
Date: Fri, 31 Aug 2001 11:37:12 +0200 [thread overview]
Message-ID: <20010831113712.L2855@suse.de> (raw)
In-Reply-To: <20010830164547.A807@btconnect.com> <20010831112020.K2855@suse.de> <20010831103541.A440@btconnect.com>
In-Reply-To: <20010831103541.A440@btconnect.com>
On Fri, Aug 31 2001, Joe Thornber wrote:
> On Fri, Aug 31, 2001 at 11:20:20AM +0200, Jens Axboe wrote:
> > On Thu, Aug 30 2001, Joe Thornber wrote:
> > > Hi,
> > >
> > > I'm working on the next iteration of the LVM driver, specifically
> > > trying to address the critism directed at the rather ugly ioctl
> > > interface. The code has reached the stage where it works and it's
> > > possible to see what I'm aiming for. I would appreciate it if people
> > > could spare the time to review this and give me feedback. If there is
> > > general agreement that this is moving in the right direction then the
> > > next major version of LVM may be based around a future version of this
> > > driver. Please CC me in replies. The code can be found at:
> > >
> > > ftp://ftp.sistina.com/pub/LVM2/device-mapper/device-mapper.tar.bz2
> >
> > Looks interesting, here's patch to fix possible infinite loop in your
> > make_request_fn.
>
> Great, thanks.
I missed a '}', jfyi
> > Another quick note -- you might want to consider
> > slab'ifying the io_hook allocation/deallocation...
>
> yes, I'd thought of this, hence the comment ...
>
> /* FIXME: These should have their own slab */
> inline static struct io_hook *alloc_io_hook(void)
>
> I'll change that now.
Oh, didn't spot that... But yet, it's a really good idea.
--
Jens Axboe
next prev parent reply other threads:[~2001-08-31 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-30 15:45 A possible direction for the next LVM driver Joe Thornber
2001-08-30 15:55 ` Alan Cox
2001-08-31 9:20 ` Jens Axboe
2001-08-31 9:35 ` Joe Thornber
2001-08-31 9:37 ` Jens Axboe [this message]
2001-12-14 19:11 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010831113712.L2855@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=thornber@btconnect.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).