From: Andreas Dilger <adilger@turbolabs.com>
To: linux-kernel@vger.kernel.org
Subject: Re: Define conflict between ext3 and raid patches against 2.2.19
Date: Sun, 16 Sep 2001 22:42:11 -0600 [thread overview]
Message-ID: <20010916224211.H1541@turbolinux.com> (raw)
In-Reply-To: <20010916155835.C24067@mikef-linux.matchmail.com> <20010917010927.A9308@schmorp.de> <20010916184339.H1564@mikef-linux.matchmail.com>
In-Reply-To: <20010916184339.H1564@mikef-linux.matchmail.com>
On Sep 16, 2001 18:43 -0700, Mike Fedyk wrote:
> > Change BH_Temp to:
> >
> > #define BH_Temp 9 /* 1 if the buffer is temporary (unlinked)
> >
> > and it should work.
> >
>
> /* bh state bits */
> #define BH_Uptodate 0 /* 1 if the buffer contains valid data */
> #define BH_Dirty 1 /* 1 if the buffer is dirty */
> #define BH_Lock 2 /* 1 if the buffer is locked */
> #define BH_Req 3 /* 0 if the buffer has been invalidated */
> #define BH_Protected 6 /* 1 if the buffer is protected */
> #define BH_Wait_IO 7 /* 1 if we should throttle on this buffer */
> #define BH_Temp 8 /* 1 if the buffer is temporary (unlinked) */
> #define BH_JWrite 9 /* 1 if being written to log (@@@ DEBUGGING)*/
> #define BH_QuickFree 10 /* 1 if alloced and freed quickly (see below)*/
> #define BH_Alloced 11 /* 1 if buffer has been allocated */
> #define BH_Freed 12 /* 1 if buffer has been freed (truncated)*/
> #define BH_Revoked 13 /* 1 if buffer has been revoked from the log*/
> #define BH_RevokeValid 14 /* 1 if buffer revoked flag is valid */
> #define BH_JDirty 15 /* 1 if buffer is dirty but journaled */
>
> As you can see, that is already taken from ext3. Is this ok?
>
> #define BH_LowPrio 16 /* 1 if the buffer is temporary (unlinked)
>
> Or do I only have 16 bits to work with?
No, you have 32 bits to work with. In my ext3-2.2 patches I just increased
all of the ext3 numbers by one. I don't think it is critical what number is
used in the end, as long as you don't get another patch defining these flags
(reiserfs uses these flags in 2.2 as well).
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
next prev parent reply other threads:[~2001-09-17 4:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-16 22:58 Define conflict between ext3 and raid patches against 2.2.19 Mike Fedyk
2001-09-16 23:09 ` Lehmann
2001-09-17 1:43 ` Mike Fedyk
2001-09-17 4:42 ` Andreas Dilger [this message]
2001-09-18 11:08 ` Neil Brown
2001-09-18 19:24 ` Mike Fedyk
2001-09-19 20:38 ` Mike Fedyk
2001-09-19 22:35 ` Neil Brown
2001-09-21 13:10 ` Stephen C. Tweedie
2001-09-21 22:44 ` Mike Fedyk
2001-10-01 21:17 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010916224211.H1541@turbolinux.com \
--to=adilger@turbolabs.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).