From: Pete Zaitcev <zaitcev@redhat.com>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: Patch to ymfpci (set_current_state repositioning)
Date: Mon, 17 Sep 2001 21:59:01 -0400 [thread overview]
Message-ID: <20010917215901.A17220@devserv.devel.redhat.com> (raw)
Dear Linus,
please consider the patch below for 2.4.10. Suggested by Arjan van
de Ven and confirmed with Alan, DaveM (I hope that I understood right
what they explained to me).
Yours,
-- Pete
--- linux-2.4.9/drivers/sound/ymfpci.c Sun Aug 12 10:51:42 2001
+++ linux-2.4.9-niph/drivers/sound/ymfpci.c Mon Sep 17 18:35:09 2001
@@ -457,11 +457,12 @@
}
#endif
+ set_current_state(TASK_UNINTERRUPTIBLE);
while (ypcm->running) {
spin_unlock_irqrestore(&unit->reg_lock, flags);
- set_current_state(TASK_UNINTERRUPTIBLE);
schedule();
spin_lock_irqsave(&unit->reg_lock, flags);
+ set_current_state(TASK_UNINTERRUPTIBLE);
}
spin_unlock_irqrestore(&unit->reg_lock, flags);
@@ -1198,12 +1199,13 @@
ret = 0;
add_wait_queue(&dmabuf->wait, &waita);
+ set_current_state(TASK_INTERRUPTIBLE);
while (count > 0) {
spin_lock_irqsave(&unit->reg_lock, flags);
if (unit->suspended) {
spin_unlock_irqrestore(&unit->reg_lock, flags);
- set_current_state(TASK_INTERRUPTIBLE);
schedule();
+ set_current_state(TASK_INTERRUPTIBLE);
if (signal_pending(current)) {
if (!ret) ret = -EAGAIN;
break;
@@ -1241,9 +1243,9 @@
is TOO LATE for the process to be scheduled to run (scheduler latency)
which results in a (potential) buffer overrun. And worse, there is
NOTHING we can do to prevent it. */
- set_current_state(TASK_INTERRUPTIBLE);
tmo = schedule_timeout(tmo);
spin_lock_irqsave(&state->unit->reg_lock, flags);
+ set_current_state(TASK_INTERRUPTIBLE);
if (tmo == 0 && dmabuf->count == 0) {
printk(KERN_ERR "ymfpci%d: recording schedule timeout, "
"dmasz %u fragsz %u count %i hwptr %u swptr %u\n",
@@ -1326,12 +1328,13 @@
redzone *= 3; /* 2 redzone + 1 possible uncertainty reserve. */
add_wait_queue(&dmabuf->wait, &waita);
+ set_current_state(TASK_INTERRUPTIBLE);
while (count > 0) {
spin_lock_irqsave(&unit->reg_lock, flags);
if (unit->suspended) {
spin_unlock_irqrestore(&unit->reg_lock, flags);
- set_current_state(TASK_INTERRUPTIBLE);
schedule();
+ set_current_state(TASK_INTERRUPTIBLE);
if (signal_pending(current)) {
if (!ret) ret = -EAGAIN;
break;
@@ -1389,8 +1392,8 @@
if (!ret) ret = -EAGAIN;
break;
}
- set_current_state(TASK_INTERRUPTIBLE);
schedule();
+ set_current_state(TASK_INTERRUPTIBLE);
if (signal_pending(current)) {
if (!ret) ret = -ERESTARTSYS;
break;
reply other threads:[~2001-09-18 1:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010917215901.A17220@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).