From: "David S. Miller" <davem@redhat.com>
To: kash@stanford.edu
Cc: linux-kernel@vger.kernel.org, mc@cs.Stanford.EDU
Subject: Re: [CHECKER] two probable security holes
Date: Mon, 24 Sep 2001 17:26:08 -0700 (PDT) [thread overview]
Message-ID: <20010924.172608.105430357.davem@redhat.com> (raw)
In-Reply-To: <Pine.GSO.4.31.0109181355560.15933-100000@saga18.Stanford.EDU>
In-Reply-To: <Pine.GSO.4.31.0109181355560.15933-100000@saga18.Stanford.EDU>
From: Ken Ashcraft <kash@stanford.edu>
Date: Tue, 18 Sep 2001 14:29:57 -0700 (PDT)
Watch ifr.ifr_name.
Hi Ken, I believe there is some bug in your new checker algorithms for
this case.
struct ifreq ifr;
int err;
Start--->
if (copy_from_user(&ifr, (void *)arg, sizeof(ifr)))
return -EFAULT;
ifr.ifr_name[IFNAMSIZ-1] = '\0';
ifreq copied safely to kernel space, ifr.ifr_name[] is inside the
struct and NOT a user pointer.
err = tun_set_iff(file, &ifr);
Pass address of kernel ifreq.
if (*ifr->ifr_name)
name = ifr->ifr_name;
if ((err = dev_alloc_name(&tun->dev, name)) < 0)
goto failed;
Perfectly fine still, name always points to kernel memory.
int dev_alloc_name(struct net_device *dev, const char *name)
{
...
for (i = 0; i < 100; i++) {
Error--->
sprintf(buf,name,i);
Still fine, as stated "name" is pointing to kernel memory.
Perhaps your code is being confused by "ifreq->if_name" being
an array.
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-09-25 0:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-18 21:29 [CHECKER] two probable security holes Ken Ashcraft
2001-09-25 0:26 ` David S. Miller [this message]
2001-09-25 0:41 ` Ken Ashcraft
2001-09-25 1:27 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010924.172608.105430357.davem@redhat.com \
--to=davem@redhat.com \
--cc=kash@stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).