linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Fedyk <mfedyk@matchmail.com>
To: Ed Tomlinson <tomlins@cam.org>
Cc: Rik van Riel <riel@conectiva.com.br>, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] vm_swap_full
Date: Sun, 4 Nov 2001 19:10:14 -0800	[thread overview]
Message-ID: <20011104191014.C16017@mikef-linux.matchmail.com> (raw)
In-Reply-To: <20011104152341.A4C289E898@oscar.casa.dyndns.org> <Pine.LNX.4.33L.0111041436020.2963-100000@imladris.surriel.com> <20011104180840.A16017@mikef-linux.matchmail.com> <20011105025817.D997216E5C@oscar.casa.dyndns.org>
In-Reply-To: <20011105025817.D997216E5C@oscar.casa.dyndns.org>

On Sun, Nov 04, 2001 at 09:58:17PM -0500, Ed Tomlinson wrote:
> On November 4, 2001 09:08 pm, Mike Fedyk wrote:
> > On Sun, Nov 04, 2001 at 02:36:34PM -0200, Rik van Riel wrote:
> > > On Sun, 4 Nov 2001, Ed Tomlinson wrote:
> > > > -/* Swap 50% full? Release swapcache more aggressively.. */
> > > > -#define vm_swap_full() (nr_swap_pages*2 < total_swap_pages)
> > > > +/* Free swap less than inactive pages? Release swapcache more
> > > > aggressively.. */ +#define vm_swap_full() (nr_swap_pages <
> > > > nr_inactive_pages)
> > > >
> > > > Comments?
> > >
> > > Makes absolutely no sense for systems which have more
> > > swap than RAM, eg. a 64MB system with 200MB of swap.
> >
> > How does the inactive list get bigger than physical ram?
> >
> > If swap is bigger than ram, there is *no* possibility of the inactive list
> > being bigger than swap, and thus no aggressive swapping...
> 
> nr_swap_pages is the number of swap pages free.  

Oh, I thought it was total swap pages...

>The idea is to start
> aggressive swap only when we are at risk of running out of swap.  This way
> we get to take full advantage of throwing away clean pages that are backed
> up by swap when under vm pressure. 
> 
Yes.  My point is that the inactive list can't get bigger than RAM, and thus
if swap is bigger than ram this case wouldn't trigger...

But now that nr_swap_pages is *free* swap, you'll have to add another test
for (swap > RAM)... 

Mike

  reply	other threads:[~2001-11-05  3:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-04 15:23 [RFC][PATCH] vm_swap_full Ed Tomlinson
2001-11-04 16:36 ` Rik van Riel
2001-11-04 17:04   ` Ed Tomlinson
2001-11-05  2:08   ` Mike Fedyk
2001-11-05  2:58     ` Ed Tomlinson
2001-11-05  3:10       ` Mike Fedyk [this message]
2001-11-05  3:15         ` Rik van Riel
2001-11-05 12:37 Ed Tomlinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011104191014.C16017@mikef-linux.matchmail.com \
    --to=mfedyk@matchmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@conectiva.com.br \
    --cc=tomlins@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).