linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: Alexander Viro <viro@math.psu.edu>
Cc: Rik van Riel <riel@conectiva.com.br>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] New devfs core
Date: Mon, 5 Nov 2001 13:03:34 -0700	[thread overview]
Message-ID: <200111052003.fA5K3YG10879@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.GSO.4.21.0111051447060.24894-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.LNX.4.33L.0111051742231.27028-100000@duckman.distro.conectiva> <Pine.GSO.4.21.0111051447060.24894-100000@weyl.math.psu.edu>

Alexander Viro writes:
> On Mon, 5 Nov 2001, Rik van Riel wrote:
> > On Mon, 5 Nov 2001, Richard Gooch wrote:
> > > But since interest has been expressed ;-) in seeing this code, here it
> > > is. So don't flame if you see problems. Remember that this is a very
> > > rough cut. I have a list of "issues" to process before I consider this
> > > alpha quality.
> > 
> > This is nice for 2.5, but I have to wonder what you're
> > going to do in order to get the bugs in 2.4 devfs fixed.
> 
> Come on.  Regardless of the quality of new code (I hadn't looked at
> the patched tree yet, but from the look at patch itself locking is
> heavily overdone, so my gut feeling is that there are deadlocks),
> it's no worse than the old one.

As I said, this is a very rough cut. I'm not actually suggesting this
is code people should run (although testing reports are always
welcome), it's a release so that people can see what I'm doing.

> I.e. as long as it doesn't touch the rest of tree, situation hadn't
> become worse.  Usual arguments re lost testing obviously do not
> apply - replaced code is known to be broken _and_ impossible to fix
> without a massive rewrite.  So all old testing had been worthless
> anyway.

Surprising as it may seem, I agree with Al. The old code has too many
problems, and can't be fixed with just a tweak here and there. A
re-write is what is needed, and a re-write is what I'm doing. The new
code will be tested, and once I'm satisfied that it works at least as
well as the old code, I'll submit it to Linus. Any remaining problems
should be much easier to fix in the new code, I hope.

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

      parent reply	other threads:[~2001-11-05 20:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-05 19:31 [PATCH] New devfs core Richard Gooch
2001-11-05 19:44 ` Rik van Riel
2001-11-05 19:51   ` Alexander Viro
2001-11-05 20:03   ` Richard Gooch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200111052003.fA5K3YG10879@vindaloo.ras.ucalgary.ca \
    --to=rgooch@ras.ucalgary.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@conectiva.com.br \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).