From: Jens Axboe <axboe@suse.de>
To: andersg@0x63.nu
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>,
rwhron@earthlink.net
Subject: Re: 2.5.1-pre3 FIXED (was Re: 2.5.1-pre3 DON'T USE)
Date: Fri, 30 Nov 2001 09:59:20 +0100 [thread overview]
Message-ID: <20011130095920.Q16796@suse.de> (raw)
In-Reply-To: <20011129091554.E5788@suse.de> <20011129121431.D10601@suse.de> <20011130095314.D21256@h55p111.delphi.afb.lu.se>
In-Reply-To: <20011130095314.D21256@h55p111.delphi.afb.lu.se>
On Fri, Nov 30 2001, andersg@0x63.nu wrote:
> On Thu, Nov 29, 2001 at 12:14:31PM +0100, Jens Axboe wrote:
> > On Thu, Nov 29 2001, Jens Axboe wrote:
> > > Hi,
> > >
> > > Please don't use this kernel unless you can afford to loose your data.
> > > I'm looking at the problem right now.
> >
> > Ok the problem was only on highmem machines, the copying of data was
> > just wrong. The attached patch fixes that and a few other buglets, such
> > as:
> >
> > - BIO_HASH remnant in LVM
>
> shouldn't line 1046 in lvm.c be:
> bio.bi_io_vec[0].bv_len = lvm_get_blksize(bio.bi_dev);
>
> with this patch it atleast compiles..
>
> --- linux-2.5.1-pre4-vanilj/drivers/md/lvm.c Fri Nov 30 09:45:31 2001
> +++ linux-2.5.1-pre4/drivers/md/lvm.c Fri Nov 30 09:32:42 2001
> @@ -1043,7 +1043,7 @@
>
> memset(&bio,0,sizeof(bio));
> bio.bi_dev = inode->i_rdev;
> - bio.bi_io_vec.bv_len = lvm_get_blksize(bio.bi_dev);
> + bio.bi_io_vec[0].bv_len = lvm_get_blksize(bio.bi_dev);
> bio.bi_sector = block * bio_sectors(&bio);
> bio.bi_rw = READ;
> if ((err=lvm_map(&bio)) < 0) {
memset(bio...) and then deref bi_io_vec, not a good idea. Then leaving
it in a non-compileable state for now is preferable.
--
Jens Axboe
prev parent reply other threads:[~2001-11-30 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-29 8:15 2.5.1-pre3 DON'T USE Jens Axboe
2001-11-29 11:14 ` 2.5.1-pre3 FIXED (was Re: 2.5.1-pre3 DON'T USE) Jens Axboe
2001-11-29 11:39 ` Alexander Viro
2001-11-29 21:10 ` Andre Hedrick
2001-11-30 8:53 ` andersg
2001-11-30 8:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011130095920.Q16796@suse.de \
--to=axboe@suse.de \
--cc=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=rwhron@earthlink.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).