From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Matthew Garrett <mjg59@codon.org.uk>
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, amitk@kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate
Date: Sat, 12 Dec 2020 10:11:31 +0100 [thread overview]
Message-ID: <20015331-955b-756f-3dce-4eb78e473704@linaro.org> (raw)
In-Reply-To: <20201212035012.GA11926@codon.org.uk>
On 12/12/2020 04:50, Matthew Garrett wrote:
> On Fri, Dec 11, 2020 at 02:17:55PM +0100, Daniel Lezcano wrote:
>> On 08/12/2020 16:30, Daniel Lezcano wrote:
>>> The passive file in sysfs forces the usage of a passive trip point set
>>> by the userspace when a broken BIOS does not provide the mitigation
>>> temperature for such thermal zone. The hardware evolved a lot since
>>> 2008 as a good thermal management is no longer an option.
>>>
>>> Linux on the other side also provides now a way to load fixed ACPI
>>> table via the option ACPI_TABLE_UPGRADE, so additionnal trip point
>>> could be added there.
>>>
>>> Set the option obsolete and plan to remove it, so the corresponding
>>> code can be removed from the core code and allow more cleanups the
>>> thermal framework deserves.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>>
>> Is there any concern about this change ?
>
> Yes - what's the reason to do so?
I'm cleaning up the thermal core code, so questioning every old ABI.
> The code isn't specific to ACPI,
> so being able to override ACPI tables doesn't seem to justify it.
I agree, the code is no specific to ACPI.
What non-ACPI architecture, without device tree or platform data would
need the 'passive' option today ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-12-12 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 15:30 [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate Daniel Lezcano
2020-12-11 13:17 ` Daniel Lezcano
2020-12-12 3:50 ` Matthew Garrett
2020-12-12 9:11 ` Daniel Lezcano [this message]
2020-12-12 20:08 ` Matthew Garrett
2020-12-12 23:39 ` Daniel Lezcano
2020-12-13 1:11 ` Matthew Garrett
2020-12-13 11:02 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20015331-955b-756f-3dce-4eb78e473704@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mjg59@codon.org.uk \
--cc=mjg59@srcf.ucam.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).