From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: joergprante@gmx.de, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.4.19pre8][RFC] remove-NFS-close-to-open from VFS (was Re: [PATCHSET] 2.4.19-pre8-jp12)
Date: Thu, 16 May 2002 23:43:57 -0400 [thread overview]
Message-ID: <20020517034357.GA18449@ravel.coda.cs.cmu.edu> (raw)
In-Reply-To: <200205162142.AWF00051@netmail.netcologne.de> <E178TUb-0005Bh-00@the-village.bc.nu>
On Thu, May 16, 2002 at 11:13:01PM +0100, Alan Cox wrote:
> > Is it possible to leave the VFS layer untouched? Or restrict the dentry
> > revalidation to NFS and let other remote file systems coexist, i.e. without
> > revalidation calls?
>
> Really the other file systems want fixing - that revalidation is a real bug
> fix and the situation could occur for other network file systems too
And I thought I broke something with my latest changes in Coda. This
'bugfix' is hitting us hard. In some cases we hand down quite volatile
objects, files that are involved in a conflict, fake expanded directory
trees during the repair/examination of such conflicts.
These object are passed down with a 'no-cache' flag, which uses
dentry_revalidate to skip the cached lookup from the dcache but forces
all lookups to be passed through to the Coda filesystem. This bugfix
causes breakage, instead of forcing a new filesystem lookup, the VFS
simply returns ESTALE.
AFAIK, before the fix, failing dentry revalidate meant 'the lookup path
in the dcache is probably invalid, please double check with the
filesystem'. And now it means, 'the lookup path is invalid, return failure'.
Jan
next prev parent reply other threads:[~2002-05-17 3:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-15 0:05 [PATCHSET] 2.4.19-pre8-jp12 Jörg Prante
2002-05-16 7:47 ` Pozsar Balazs
2002-05-16 9:05 ` Tomas Szepe
2002-05-16 9:19 ` Pozsar Balazs
2002-05-16 15:08 ` Robinson Maureira Castillo
2002-05-16 21:40 ` [PATCH 2.4.19pre8][RFC] remove-NFS-close-to-open from VFS (was Re: [PATCHSET] 2.4.19-pre8-jp12) Jörg Prante
2002-05-16 22:13 ` Alan Cox
2002-05-16 23:36 ` [PATCH] fixing supermount for > 2.4.19pre4 Jörg Prante
2002-05-17 3:04 ` [PATCH 2.4.19pre8][RFC] remove-NFS-close-to-open from VFS (was Re: [PATCHSET] 2.4.19-pre8-jp12) Tomas Szepe
2002-05-17 3:43 ` Jan Harkes [this message]
2002-05-16 18:33 ` [PATCHSET] 2.4.19-pre8-jp12 Jörg Prante
2002-05-16 19:39 ` Jörg Prante
2002-05-17 23:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020517034357.GA18449@ravel.coda.cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=joergprante@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).