From: Christoph Hellwig <hch@infradead.org>
To: Stephen Tweedie <sct@redhat.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>, linux-kernel@vger.kernel.org
Subject: Re: [Patch 5/8] 2.4.20-pre4/ext3: Fix O_SYNC for non-data-journaled modes.
Date: Wed, 28 Aug 2002 17:18:13 +0100 [thread overview]
Message-ID: <20020828171813.A2661@infradead.org> (raw)
In-Reply-To: <200208281545.g7SFjKE14338@sisko.scot.redhat.com>; from sct@redhat.com on Wed, Aug 28, 2002 at 04:45:20PM +0100
On Wed, Aug 28, 2002 at 04:45:20PM +0100, Stephen Tweedie wrote:
> ext3 has its own code which marks buffers dirty, in addition to the setting
> done by the core generic_commit_write code. However, the core code does
>
> if (!atomic_set_buffer_dirty(bh)) {
> __mark_dirty(bh);
> buffer_insert_inode_queue(bh, inode);
>
> so if ext3 marks the buffer dirty itself, the core fails to put it on the
> per-inode list of dirty buffers. Hence, fsync_inode_buffers() misses it.
>
> The fix is to let ext3 put the buffer on the inode queue manually when
> walking the page's buffer lists in its page write code.
This patch conflicts with the b_inode as bool patch you recently ACKed..
next prev parent reply other threads:[~2002-08-28 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-28 15:45 [Patch 5/8] 2.4.20-pre4/ext3: Fix O_SYNC for non-data-journaled modes Stephen Tweedie
2002-08-28 16:18 ` Christoph Hellwig [this message]
2002-08-28 16:26 ` Stephen C. Tweedie
2002-08-28 16:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020828171813.A2661@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).