From: Russell King <rmk@arm.linux.org.uk>
To: linux-kernel@vger.kernel.org
Subject: Re: 2.4.19 SCSI core bug?
Date: Thu, 12 Sep 2002 10:01:40 +0100 [thread overview]
Message-ID: <20020912100140.A32196@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020911221859.A17951@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Wed, Sep 11, 2002 at 10:19:00PM +0100
On Wed, Sep 11, 2002 at 10:19:00PM +0100, Russell King wrote:
> Ok, so we were asking for 0xfe 512-byte sectors, which is 130048.
> So why did SCSI tell me that it wanted 38400 bytes in
> SCpnt->request_bufflen?
Ok, problem found.
There's a nice loop in scsi_send_eh_cmnd() which just loops endlessly
trying to retry a SCpnt command on medium error without restoring it
to its pristine state before giving it back to the host, or limiting
the number of retries.
The end result is that the SCSI command says N sectors, the request
list may say N * sector size bytes, but SCpnt->request_bufflen may
be complete rubbish, since the HBA driver is allowed to modify this
field during the processing of a command.
We do have a specific function to restore the SCSI command data to
a pristine state (scsi_eh_retry_command).
Ok, so there's two bugs here:
1. It's possible for SCSI to completely bring a box to a complete
standstill when it encounters a SCSI error.
2. Not retrying the command in its correct state.
I'll look at cooking up a patch for both of these in the next few days
or so.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-09-12 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-11 21:19 2.4.19 SCSI core bug? Russell King
2002-09-12 9:01 ` Russell King [this message]
2002-09-12 15:39 ` Mike Anderson
2002-09-12 15:42 ` Russell King
2002-09-12 16:45 ` Russell King
2002-09-12 9:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020912100140.A32196@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).