linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Generated files destruction
@ 2002-09-12  7:13 Rusty Russell
  2002-09-12 20:53 ` Kai Germaschewski
  0 siblings, 1 reply; 4+ messages in thread
From: Rusty Russell @ 2002-09-12  7:13 UTC (permalink / raw)
  To: torvalds, Kai Germaschewski; +Cc: linux-kernel

Linus, please apply.

	I would like to start migrating all build-generated files to
names matching "generated*" or ".generated*", esp. those which look
like source files.  This is mainly for readability and for simplicity
when diffing built kernel trees.  I'll be encouraging various
maintainers who generate (.c, .h and .s) files which are not meant to
be shipped with the kernel source to migrate, in my copious free
time...

Cheers!
Rusty.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.34/Makefile working-2.5.34-generated-remove/Makefile
--- linux-2.5.34/Makefile	2002-09-10 09:11:14.000000000 +1000
+++ working-2.5.34-generated-remove/Makefile	2002-09-12 17:09:06.000000000 +1000
@@ -660,6 +660,7 @@ clean:	archclean
 	@echo 'Cleaning up'
 	@find . -name SCCS -prune -o -name BitKeeper -prune -o \
 		\( -name \*.[oas] -o -name core -o -name .\*.cmd -o \
+		-name generated\* -o -name .generated\* -o \
 		-name .\*.tmp -o -name .\*.d \) -type f -print \
 		| grep -v lxdialog/ | xargs rm -f
 	@rm -f $(CLEAN_FILES)

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Generated files destruction
  2002-09-12  7:13 [PATCH] Generated files destruction Rusty Russell
@ 2002-09-12 20:53 ` Kai Germaschewski
  2002-09-13  0:42   ` Rusty Russell
  2002-09-30 16:23   ` Linus Torvalds
  0 siblings, 2 replies; 4+ messages in thread
From: Kai Germaschewski @ 2002-09-12 20:53 UTC (permalink / raw)
  To: Rusty Russell; +Cc: torvalds, linux-kernel

On Thu, 12 Sep 2002, Rusty Russell wrote:

> 	I would like to start migrating all build-generated files to
> names matching "generated*" or ".generated*", esp. those which look
> like source files.  This is mainly for readability and for simplicity
> when diffing built kernel trees.  I'll be encouraging various
> maintainers who generate (.c, .h and .s) files which are not meant to
> be shipped with the kernel source to migrate, in my copious free
> time...

I think the proper solution here is actually separate obj/src dirs, 
instead of special names. It's actually quite easy to get that implemented 
in the current kbuild, I just didn't find the time for proper testing yet. 
I'll have a patch ready for testing soon, though.

-Kai



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Generated files destruction
  2002-09-12 20:53 ` Kai Germaschewski
@ 2002-09-13  0:42   ` Rusty Russell
  2002-09-30 16:23   ` Linus Torvalds
  1 sibling, 0 replies; 4+ messages in thread
From: Rusty Russell @ 2002-09-13  0:42 UTC (permalink / raw)
  To: Kai Germaschewski; +Cc: torvalds, linux-kernel

In message <Pine.LNX.4.44.0209121551010.31494-100000@chaos.physics.uiowa.edu> y
ou write:
> On Thu, 12 Sep 2002, Rusty Russell wrote:
> 
> > 	I would like to start migrating all build-generated files to
> > names matching "generated*" or ".generated*", esp. those which look
> > like source files.  This is mainly for readability and for simplicity
> > when diffing built kernel trees.  I'll be encouraging various
> > maintainers who generate (.c, .h and .s) files which are not meant to
> > be shipped with the kernel source to migrate, in my copious free
> > time...
> 
> I think the proper solution here is actually separate obj/src dirs, 
> instead of special names. It's actually quite easy to get that implemented 
> in the current kbuild, I just didn't find the time for proper testing yet. 
> I'll have a patch ready for testing soon, though.

Sure, if it basically comes for free.  Otherwise, I don't see any
attraction in separating them: cp -al linux-2.5.34 working-2.5.34-foo
takes a couple of seconds.

Cheers!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Generated files destruction
  2002-09-12 20:53 ` Kai Germaschewski
  2002-09-13  0:42   ` Rusty Russell
@ 2002-09-30 16:23   ` Linus Torvalds
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Torvalds @ 2002-09-30 16:23 UTC (permalink / raw)
  To: Kai Germaschewski; +Cc: Rusty Russell, linux-kernel


On Thu, 12 Sep 2002, Kai Germaschewski wrote:
> 
> I think the proper solution here is actually separate obj/src dirs, 
> instead of special names. It's actually quite easy to get that implemented 
> in the current kbuild, I just didn't find the time for proper testing yet. 
> I'll have a patch ready for testing soon, though.

Please keep in mind that some people (at least me) don't like separate
build trees - I do all the "real work" in the source directory, and if I
need to go somewhere else to build, that's just a pain (and it's another
pain if, once I'm building, I have to use a different path than the one
that I'm used to in the source directory to fix something).

So I want to keep the mixed tree around (which is not to say that people 
who like the separate-object-tree thing shouldn't be _able_ to use it).

		Linus


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-09-30 16:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-12  7:13 [PATCH] Generated files destruction Rusty Russell
2002-09-12 20:53 ` Kai Germaschewski
2002-09-13  0:42   ` Rusty Russell
2002-09-30 16:23   ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).