2.5.36 compile error (ide-cd) any fix yet ?

2.5.36 compile error (ide-cd) any fix yet ?

[Corporal Pisang]

Hi,

Any fixes yet for this compile error ?

gcc -Wp,-MD,./.ide-cd.o.d -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon  -nostdinc -iwithprefix include    -DKBUILD_BASENAME=ide_cd   -c -o ide-cd.o ide-cd.c
In file included from ide-cd.c:318:
ide-cd.h:440: error: long, short, signed or unsigned used invalidly for `slot_tablelen'
ide-cd.c: In function `cdrom_analyze_sense_data':
ide-cd.c:468: warning: comparison between signed and unsigned
ide-cd.c: In function `cdrom_buffer_sectors':
ide-cd.c:913: warning: comparison between signed and unsigned
ide-cd.c:913: warning: signed and unsigned type in conditional expression
ide-cd.c: In function `cdrom_read_intr':
ide-cd.c:1091: warning: comparison between signed and unsigned
ide-cd.c:1091: warning: signed and unsigned type in conditional expression
ide-cd.c: In function `cdrom_write_intr':
ide-cd.c:1652: warning: comparison between signed and unsigned
ide-cd.c:1652: warning: signed and unsigned type in conditional expression
make[2]: *** [ide-cd.o] Error 1
make[2]: Leaving directory `/usr/src/linux/drivers/ide'
make[1]: *** [ide] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [drivers] Error 2


Regards

-Ubaida-

Re: 2.5.36 compile error (ide-cd) any fix yet ?

[Skip Ford]

Corporal Pisang wrote:
> Any fixes yet for this compile error ?
> 
> gcc -Wp,-MD,./.ide-cd.o.d -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon  -nostdinc -iwithprefix include    -DKBUILD_BASENAME=ide_cd   -c -o ide-cd.o ide-cd.c
> In file included from ide-cd.c:318:
> ide-cd.h:440: error: long, short, signed or unsigned used invalidly for `slot_tablelen'

I looked at this last time you reported it.  Which compiler are you
using?

Line 440 of ide-cd.h is:

	__u8 short slot_tablelen;

'short' doesn't make any sense there.  __u8 is unsigned char.
I can't figure out why you're the only one getting an error.  That
change went in a few kernels ago and I've compiled ide-cd in every one
of them and it compiles fine for me.

-- 
Skip