From: Suparna Bhattacharya <suparna@in.ibm.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Benjamin LaHaise <bcrl@redhat.com>,
linux-kernel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [RFC] [PATCH] 2.5.35 patch for making DIO async
Date: Thu, 19 Sep 2002 17:06:18 +0530 [thread overview]
Message-ID: <20020919170618.B2285@in.ibm.com> (raw)
In-Reply-To: <20020919162214.A2285@in.ibm.com>; from suparna@in.ibm.com on Thu, Sep 19, 2002 at 04:22:14PM +0530
On Thu, Sep 19, 2002 at 04:22:14PM +0530, Suparna Bhattacharya wrote:
> On Wed, Sep 18, 2002 at 01:47:06PM -0700, Badari Pulavarty wrote:
> > Ben,
> >
> > aio_read/aio_write() are now working with a minor fix to fs/aio.c
> >
> > io_submit_one():
> >
> > if (likely(EIOCBQUEUED == ret))
> >
> > needs to be changed to
> >
> > if (likely(-EIOCBQUEUED == ret))
> > ^^^
> >
> >
> > I was wondering what happens to following case (I think this
> > happend in my test program).
> >
> > Lets say, I did an sys_io_submit() and my test program did exit().
> > When the IO complete happend, it tried to do following and got
> > an OOPS in aio_complete().
> >
> > if (ctx == &ctx->mm->default_kioctx) {
> >
> > I think "mm" is freed up, when process exited. Do you think this is
> > possible ? How do we handle this ?
>
> Do you see this only in the sync case ?
> init_sync_iocb ought to increment ctx->reqs_active, so that
> exit_aio waits for the iocb's to complete.
Sorry, guess in the sync case, exit_aio shouldn't happen since
the current thread still has a reference to the mm.
And your problem is with the io_submit case ... have to look closely
to find out why.
>
> Regards
> Suparna
> --
> To unsubscribe, send a message with 'unsubscribe linux-aio' in
> the body to majordomo@kvack.org. For more info on Linux AIO,
> see: http://www.kvack.org/aio/
prev parent reply other threads:[~2002-09-19 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-17 21:03 [RFC] [PATCH] 2.5.35 patch for making DIO async Badari Pulavarty
2002-09-18 11:51 ` Benjamin LaHaise
2002-09-18 15:58 ` Badari Pulavarty
2002-09-18 16:04 ` Benjamin LaHaise
2002-09-18 16:30 ` Badari Pulavarty
2002-09-18 20:47 ` Badari Pulavarty
2002-09-19 10:52 ` Suparna Bhattacharya
2002-09-19 11:36 ` Suparna Bhattacharya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020919170618.B2285@in.ibm.com \
--to=suparna@in.ibm.com \
--cc=bcrl@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).