From: Dave Olien <firstname.lastname@example.org> To: email@example.com Cc: "David S. Miller" <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: DAC960 in 2.5.38, with new changes Date: Tue, 24 Sep 2002 11:45:43 -0700 [thread overview] Message-ID: <20020924114543.E17658@acpi.pdx.osdl.net> (raw) In-Reply-To: <firstname.lastname@example.org>; from email@example.com on Tue, Sep 24, 2002 at 11:21:45AM -0700 I'm looking over the main body of the interrupt handler for the DAC960 ( the DAC960_V_ProcessCompletedCommand()). The V1 version of this function is over 800 lines long. The V2 version is 600 lines long. First off I have an intense dislike for ANY function that is this long. Secondly, most of the stuff in these functions doesn't seem appropriate for an interrupt handler. 90% of the code in these functions is executed rarely, and isn't performance critical. Most of these functions involve health monitoring. In some cases, where logical drives appear or disappear, the set of disks visible through the controller must change. It seems to me that most of this functionality should be moved into a kernel daemon associated with the driver. The interrupt handler could be shrunk to as few instructions and "if then else" branches as possible, to shorten the time the spent in the handler and the time the controller's lock is held. This is a bigger change than I'm ready to deal with right now. First thing is to get the old code structure to work with the DMA interfaces. But I think daemon-izing this code would clean it up and make it more easily understood as well. Perhaps we could do this as part of a "stage-two" set of changes.
next prev parent reply other threads:[~2002-09-24 18:40 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2002-09-23 19:04 Dave Olien 2002-09-23 19:19 ` David Mosberger 2002-09-23 20:40 ` David S. Miller 2002-09-23 20:53 ` David Mosberger 2002-09-23 20:57 ` David S. Miller 2002-09-23 21:24 ` David Mosberger 2002-09-23 21:17 ` David S. Miller 2002-09-23 21:32 ` David Mosberger 2002-09-23 21:28 ` David S. Miller 2002-09-23 21:31 ` Daniel Phillips 2002-09-23 21:33 ` David Mosberger 2002-09-23 21:28 ` David S. Miller 2002-09-23 21:40 ` Daniel Phillips 2002-09-23 21:45 ` David Mosberger 2002-09-23 20:44 ` Daniel Phillips 2002-09-23 20:54 ` David S. Miller 2002-09-24 16:54 ` Dave Olien 2002-09-24 17:11 ` David Mosberger 2002-09-24 17:28 ` Dave Olien 2002-09-24 18:21 ` David Mosberger 2002-09-24 18:25 ` Dave Olien 2002-09-24 19:12 ` David Mosberger 2002-09-24 18:45 ` Dave Olien [this message] 2002-09-24 17:50 ` Daniel Phillips 2002-09-24 18:27 ` David Mosberger 2002-09-24 17:39 ` Daniel Phillips 2002-09-25 22:20 ` DAC960, documentation links Daniel Phillips 2002-09-25 22:23 ` Daniel Phillips 2002-09-26 0:02 ` Mr. James W. Laferriere 2002-09-26 16:13 ` DAC960 in 2.5.38, with new changes Alan Cox 2002-09-24 17:45 ` Daniel Phillips 2002-09-25 21:42 ` davide.rossetti 2002-09-23 20:39 ` Daniel Phillips 2002-09-23 21:41 ` Dave Olien 2002-09-23 21:53 ` Daniel Phillips 2002-09-23 22:03 ` Dave Olien 2002-09-23 22:22 ` Daniel Phillips
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20020924114543.E17658@acpi.pdx.osdl.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: DAC960 in 2.5.38, with new changes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).