linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Levon <movement@marcelothewonderpenguin.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] oprofile 2.5.38 patch
Date: Tue, 24 Sep 2002 13:55:27 +0100	[thread overview]
Message-ID: <20020924125527.GA53972@compsoc.man.ac.uk> (raw)
In-Reply-To: <p73r8fjsgl8.fsf@oldwotan.suse.de>

On Tue, Sep 24, 2002 at 02:43:47PM +0200, Andi Kleen wrote:

> wouldn't an on stack buffer do nicely to format a single number ? 

Yes, this was a lazy adaption of other code. Will fix.

> it doesn't length limit count before passing to kmalloc - hole.
> Also has overflow bugs (consider someone passing 0xffffffff-1). 

Thanks.

> The sys_lookup_dcookie call looks like a security hole to me. After

I'll make it CAP_SYS_ADMIN ?

> Adding a list_head to task_struct looks quite ugly to me. Is there
> surely no better way ? e.g. you could just put it in a file private
> structure and the daemon keeps the file open.

Well, if I'm going to "hard code" the unregister I can just remove the
registration and let the oprofile code call dcookie_init/exit on event
buffer open/release.

thanks
john

  reply	other threads:[~2002-09-24 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20020923222933.GA33523@compsoc.man.ac.uk.suse.lists.linux.kernel>
2002-09-24 12:43 ` [PATCH][RFC] oprofile 2.5.38 patch Andi Kleen
2002-09-24 12:55   ` John Levon [this message]
2002-09-23 22:29 John Levon
2002-09-24 18:48 ` Christoph Hellwig
2002-09-24 12:23   ` John Levon
2002-09-26 16:08 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020924125527.GA53972@compsoc.man.ac.uk \
    --to=movement@marcelothewonderpenguin.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).