From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <willy@debian.org>
Cc: gerg@snapgear.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: 2.5.38uc1 (MMU-less support)
Date: Wed, 25 Sep 2002 08:43:00 -0700 [thread overview]
Message-ID: <20020925154300.GF30339@kroah.com> (raw)
In-Reply-To: <20020925151943.B25721@parcelfarce.linux.theplanet.co.uk>
On Wed, Sep 25, 2002 at 03:19:43PM +0100, Matthew Wilcox wrote:
> * You're defining CONFIG_* variables in the .c file. I don't know whether
> this is something we're still trying to avoid doing ... Greg, you seem
> to be CodingStyle enforcer, what's the word?
I haven't seen that used very much, but I would not recommend it. Why
not just move it to the Config.in file? And if they are always set,
just remove them.
next prev parent reply other threads:[~2002-09-25 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-25 14:19 [PATCH]: 2.5.38uc1 (MMU-less support) Matthew Wilcox
2002-09-25 15:33 ` Greg Ungerer
2002-09-25 15:43 ` Greg KH [this message]
2002-09-26 2:35 ` Greg Ungerer
2002-09-26 3:19 ` Randy Dunlap
2002-09-26 4:29 ` Greg Ungerer
2002-09-26 14:56 ` Matthew Wilcox
2002-09-27 4:09 ` Greg Ungerer
2002-09-26 6:07 ` Greg Ungerer
-- strict thread matches above, loose matches on Subject: below --
2002-09-25 3:48 Greg Ungerer
2002-09-25 15:45 ` Greg KH
2002-09-25 23:57 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020925154300.GF30339@kroah.com \
--to=greg@kroah.com \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).