From: Daniel Jacobowitz <dan@debian.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] exit-fix-2.5.38-E3
Date: Wed, 25 Sep 2002 16:13:38 -0400 [thread overview]
Message-ID: <20020925201338.GA32366@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0209252113280.16723-100000@localhost.localdomain>
On Wed, Sep 25, 2002 at 09:20:01PM +0200, Ingo Molnar wrote:
> @@ -57,31 +58,31 @@
> void release_task(struct task_struct * p)
> {
> struct dentry *proc_dentry;
> + task_t *leader;
>
> - if (p->state != TASK_ZOMBIE)
> + if (p->state < TASK_ZOMBIE)
Could you check TASK_ZOMBIE and TASK_DEAD explicitly, or add a comment
in sched.h saying that only DEAD should be above ZOMBIE? Otherwise, if
someone needs a new task state, this'll get out of sync.
Just my 2c.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-09-25 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-25 19:20 [patch] exit-fix-2.5.38-E3 Ingo Molnar
2002-09-25 20:13 ` Daniel Jacobowitz [this message]
2002-09-25 20:28 ` Rik van Riel
2002-09-25 20:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020925201338.GA32366@nevyn.them.org \
--to=dan@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).