From: Greg KH <greg@kroah.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Patrick Mochel <mochel@osdl.org>
Subject: Re: [linux-usb-devel] [RFC] consolidate /sbin/hotplug call for pci and usb
Date: Wed, 25 Sep 2002 17:25:54 -0700 [thread overview]
Message-ID: <20020926002554.GB518@kroah.com> (raw)
In-Reply-To: <3D9250CD.7090409@pacbell.net>
On Wed, Sep 25, 2002 at 05:11:57PM -0700, David Brownell wrote:
>
> >+ /* stuff we want to pass to /sbin/hotplug */
> >+ envp[i++] = scratch;
> >+ scratch += sprintf (scratch, "PCI_CLASS=%04X", pdev->class) + 1;
> >+
> >+ envp[i++] = scratch;
> >+ scratch += sprintf (scratch, "PCI_ID=%04X:%04X",
> >+ pdev->vendor, pdev->device) + 1;
>
> And so forth. Use "snprintf" and prevent overrunning those buffers...
Doh, will do.
I also found the unload USB module problem. The driver core was calling
hotplug after the device was already removed. Made it a bit difficult
to be able to describe the device that way :)
thanks,
greg k-h
next prev parent reply other threads:[~2002-09-26 0:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-25 21:29 [RFC] consolidate /sbin/hotplug call for pci and usb Greg KH
2002-09-25 22:04 ` Kai Germaschewski
2002-09-25 22:48 ` Greg KH
2002-09-26 0:11 ` [linux-usb-devel] " David Brownell
2002-09-26 0:25 ` Greg KH [this message]
2002-09-26 2:44 ` David Brownell
2002-09-26 4:27 ` Greg KH
2002-09-26 16:14 ` David Brownell
2002-09-26 18:43 ` Greg KH
2002-09-26 19:32 ` David Brownell
2002-09-26 19:34 ` Alan Stern
2002-09-26 23:35 ` [linux-usb-devel] [RFC] consolidate /sbin/hotplug call for pciand usb Oliver Neukum
2002-09-26 17:48 ` [RFC] consolidate /sbin/hotplug call for pci and usb - take 2 Greg KH
[not found] <20020925212955.GA32487@kroah.com.suse.lists.linux.kernel>
[not found] ` <3D9250CD.7090409@pacbell.net.suse.lists.linux.kernel>
2002-09-26 0:33 ` [linux-usb-devel] [RFC] consolidate /sbin/hotplug call for pci and usb Andi Kleen
2002-09-26 0:46 ` Matthew Dharm
2002-09-26 1:01 ` Andi Kleen
2002-09-26 2:30 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020926002554.GB518@kroah.com \
--to=greg@kroah.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).