archive mirror
 help / color / mirror / Atom feed
From: Jean Tourrilhes <>
To: Marcelo Tosatti <>,
	Alan Cox <>,,
	Linux kernel mailing list <>
Subject: [PATCH 2.4.20-pre8] irtty MODEM_BITS additional fix
Date: Wed, 25 Sep 2002 19:39:50 -0700	[thread overview]
Message-ID: <> (raw)

	Hi Marcelo,

	Alan did fix the compile of the irtty driver for i386 in
pre8. Unfortunately, there is still many platforms which doesn't
compile, including some that I know where IrDA is heavily used (PPC,
	This patch make sure the code works on all platforms. It's
2.4.X, so I guess the code *must* work.



P.S. : Russel : this is an opportunity to fix the ARM platform
difference in the proper way. I guess irtty is still used on some ARM
platforms (especially with serial dongles).


--- linux/drivers/net/irda/irtty.a0.c	Wed Sep 25 19:10:25 2002
+++ linux/drivers/net/irda/irtty.c	Wed Sep 25 19:18:14 2002
@@ -46,6 +46,19 @@ static struct tty_ldisc irda_ldisc;
 static int qos_mtt_bits = 0x03;      /* 5 ms or more */
+/* To workaround some of the difference in the serial driver over various
+ * arch, some people have introduced TIOCM_MODEM_BITS.
+ * Unfortunately, this is not yet defined on all architectures, so
+ * we make sure the code is still usable. - Jean II */
+#warning "Please define TIOCM_MODEM_BITS in termios.h !"
+#ifdef TIOCM_OUT2
+#define TIOCM_MODEM_BITS	TIOCM_OUT2	/* Most architectures */
+#define TIOCM_MODEM_BITS	0		/* Not defined for ARM */
 /* Network device fuction prototypes */
 static int  irtty_hard_xmit(struct sk_buff *skb, struct net_device *dev);
 static int  irtty_net_init(struct net_device *dev);

             reply	other threads:[~2002-09-26  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-26  2:39 Jean Tourrilhes [this message]
2002-09-30 21:23 ` [PATCH 2.4.20-pre8] irtty MODEM_BITS additional fix Marcelo Tosatti
2002-09-30 23:26   ` Jean Tourrilhes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).