archive mirror
 help / color / mirror / Atom feed
From: Stephen Tweedie <>
To: Marcelo Tosatti <>,
Cc: Stephen Tweedie <>
Subject: [Patch 4/7] 2.4.20-pre4/ext3: Sanity check for Intermezzo/ext3 interactions
Date: Thu, 26 Sep 2002 14:55:32 +0100	[thread overview]
Message-ID: <> (raw)

>From Andreas Dilger:

Nowhere in journal_start() (or more specifically in start_this_handle()
is any sanity checking on the number of blocks requested for a single
handle done.  If you request more than journal_size/4 blocks for a handle
it will loop endlessly on repeat_locked: trying to "free" enough blocks
to satisfy the request.  The below patch validates the number of blocks
requested is small enough to actually be allocated, otherwise returns

--- linux-2.4-ext3merge/fs/jbd/transaction.c.=K0003=.orig	Thu Sep 26 12:25:37 2002
+++ linux-2.4-ext3merge/fs/jbd/transaction.c	Thu Sep 26 12:25:37 2002
@@ -90,7 +90,14 @@
 	transaction_t *transaction;
 	int needed;
 	int nblocks = handle->h_buffer_credits;
+	if (nblocks > journal->j_max_transaction_buffers) {
+		jbd_debug(1, "JBD: %s wants too many credits (%d > %d)\n",
+		       current->comm, nblocks,
+		       journal->j_max_transaction_buffers);
+		return -ENOSPC;
+	}
 	jbd_debug(3, "New handle %p going live.\n", handle);

                 reply	other threads:[~2002-09-26 13:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).