From: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Linus Torvalds" <torvalds@transmeta.com>,
"Andre Hedrick" <andre@linux-ide.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jens Axboe" <axboe@suse.de>
Subject: Re: [PATCH] fix ide-iops for big endian archs
Date: Thu, 26 Sep 2002 17:14:14 +0200 [thread overview]
Message-ID: <20020926151414.26040@192.168.4.1> (raw)
In-Reply-To: <1033052967.1348.30.camel@irongate.swansea.linux.org.uk>
>On Wed, 2002-09-25 at 13:32, Benjamin Herrenschmidt wrote:
>> I enclosed the patch as an attachement too in case the mailer screws
>> it up...
>
>Please do one thing. For the stuff that needs weird powerpcisms put all
>the seperate stuff in one block with its own copy of the static inlines
>so we dont have in ifdef in half the functions in the file
This is _NOT_ a weird PowerPC'ism !!!
It's just a matter of use the proper operation, that is "insw/outsw"
instead of trying to re-implement it with a loop of basic inw/outw,
which is wrong for _any_ BE arch (except maybe weird m68k'ism where
IDE is wired the wrong way around)
Ben.
next prev parent reply other threads:[~2002-09-26 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-25 12:32 [PATCH] fix ide-iops for big endian archs Benjamin Herrenschmidt
2002-09-25 18:22 ` Linus Torvalds
2002-09-25 22:44 ` Benjamin Herrenschmidt
2002-09-26 15:11 ` Alan Cox
2002-09-26 15:16 ` Benjamin Herrenschmidt
2002-09-26 16:04 ` Benjamin Herrenschmidt
2002-09-26 15:09 ` Alan Cox
2002-09-26 15:14 ` Benjamin Herrenschmidt [this message]
2002-09-26 20:58 ` Richard Zidlicky
2002-09-26 21:03 ` Benjamin Herrenschmidt
[not found] <mailman.1032957359.10217.linux-kernel2news@redhat.com>
2002-09-25 18:19 ` Pete Zaitcev
2002-09-25 19:57 ` David S. Miller
2002-09-25 22:49 ` Benjamin Herrenschmidt
2002-09-25 22:48 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020926151414.26040@192.168.4.1 \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).