From: Ryan Cumming <firstname.lastname@example.org> To: "Theodore Ts'o" <email@example.com> Cc: Andreas Dilger <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [BK PATCH] Add ext3 indexed directory (htree) support Date: Sat, 28 Sep 2002 15:30:35 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20020928141330.GA653@think.thunk.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On September 28, 2002 07:13, Theodore Ts'o wrote: > I've been able to replicate it now fairly reliably, with the attached > shell script and 2.4.19 with the 2.4.19-2 dxdir patch. Yes, that was what I'm using > It appears to > be somewhat timing dependent, as where the directory corruption occurs > is not consistent, but I believe it is in the split code. Since > e2fsck -fD packs all of the directories completely, it means that any > attempt to add a file to directory will guarantee at least one split, > and possibly two levels of tree splits. Since the -D option to e2fsck > has only been relatively recently been available, I believe this is > why it hasn't been noticed up until now in the testing; directories > which are indexed "naturally" as they grow don't appear to trigger the > problem, or are very, very unlikely to trigger the problem. (One > potential avenue for exploration is that -D option perfectly sorts all > of the directory entries in hash order, which doesn't normally occur > for naturally grown directories, and this may be triggering a > fencepost error in the split code.) Yes, running fsck -D seemed to make my loopback filesystem more brittle. I have triggered corruption without fsck, but it's much more difficult. That seems to match your description of the problem. - -Ryan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (GNU/Linux) iD8DBQE9li2QLGMzRzbJfbQRAlSfAJ93gPP65tXjzsyGiOjvoDlGwk5WrACeIILY QKk+DpMb9kpq7rsiaSSuJHs= =LoWq -----END PGP SIGNATURE-----
next prev parent reply other threads:[~2002-09-28 22:25 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2002-09-25 20:03 tytso 2002-09-25 20:34 ` Andreas Dilger 2002-09-25 20:41 ` Dave Jones 2002-09-25 21:08 ` Andreas Dilger 2002-09-25 21:34 ` Theodore Ts'o 2002-09-25 22:54 ` Jeff Garzik 2002-09-25 23:29 ` Theodore Ts'o 2002-09-25 23:45 ` Ryan Cumming 2002-09-26 3:27 ` Theodore Ts'o 2002-09-26 5:23 ` Ryan Cumming 2002-09-26 5:57 ` Theodore Ts'o 2002-09-26 6:22 ` Ryan Cumming 2002-09-26 14:05 ` Theodore Ts'o 2002-09-26 6:25 ` Ryan Cumming 2002-09-26 11:25 ` Daniel Egger 2002-09-26 7:41 ` Ryan Cumming 2002-09-26 13:23 ` Theodore Ts'o 2002-09-26 15:42 ` Theodore Ts'o 2002-09-26 19:08 ` Ryan Cumming 2002-09-26 19:51 ` Horst von Brand 2002-09-26 19:59 ` Ryan Cumming 2002-09-26 22:04 ` Theodore Ts'o 2002-09-26 22:53 ` Ryan Cumming 2002-09-26 23:57 ` Theodore Ts'o 2002-09-27 1:00 ` Ryan Cumming 2002-09-27 3:24 ` Theodore Ts'o 2002-09-27 4:12 ` Andreas Dilger 2002-09-27 7:55 ` Ryan Cumming 2002-09-28 1:20 ` Ryan Cumming 2002-09-28 1:46 ` Ryan Cumming 2002-09-28 14:13 ` Theodore Ts'o 2002-09-28 14:18 ` Theodore Ts'o 2002-09-28 22:35 ` Ryan Cumming 2002-09-28 17:27 ` [Ext2-devel] " Andreas Dilger 2002-09-28 18:43 ` chrisl 2002-09-28 19:45 ` chrisl 2002-09-28 22:30 ` Ryan Cumming [this message] 2002-09-29 7:03 ` [PATCH] fix htree dir corrupt after fsck -fD chrisl 2002-09-29 8:16 ` Ryan Cumming 2002-09-29 8:36 ` Ryan Cumming 2002-09-30 2:46 ` Ryan Cumming 2002-09-29 14:13 ` Theodore Ts'o 2002-09-25 23:31 ` [BK PATCH] Add ext3 indexed directory (htree) support Daniel Egger 2002-09-26 0:32 ` Randy.Dunlap 2002-09-26 0:50 ` Aaron Lehmann 2002-09-26 3:28 ` Theodore Ts'o 2002-10-02 9:11 tytso
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [BK PATCH] Add ext3 indexed directory (htree) support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).