From: chrisl@gnuchina.org
To: "Theodore Ts'o" <tytso@mit.edu>,
Ryan Cumming <ryan@completely.kicks-ass.org>,
linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] Re: [BK PATCH] Add ext3 indexed directory (htree) support
Date: Sat, 28 Sep 2002 12:45:13 -0700 [thread overview]
Message-ID: <20020928194513.GA1254@vmware.com> (raw)
In-Reply-To: <20020928172748.GF22795@clusterfs.com>
That is exactly the case. Now I am looking what where is those entry
come from. Remove entry should merge with the previous one.
Add a check in dx_make_map will help.
Chris
On Sat, Sep 28, 2002 at 11:27:49AM -0600, Andreas Dilger wrote:
> On Sep 28, 2002 10:13 -0400, Theodore Ts'o wrote:
> > The nature of the corruption is that a directory entry of size 8
> > (which is enough room for a zero-length name) is left in the
> > directory. This is harmless, but it should never happen normally, and
> > so the ext3 sanity-checking code flags it as an error. With this
> > patch, e2fsck is much smarter about salvaging corrupt directories, and
> > so it can do so without causing any directory entries to be lost.
> > (This corrupted, too-small directory entry appears at the beginning of
> > the directory block, which is another reason why I strongly suspect
> > the dx_split code.)
>
> One idea I just had but don't have time to investigate (babysitting
> both kids today) is if the do_split() code is creating a hash entry
> for unused dir entries (i.e. inode == 0 or name_len == 0). If that
> is the case, then it could explain the presence of this short entry.
>
> Cheers, Andreas
> --
> Andreas Dilger
> http://www-mddsp.enel.ucalgary.ca/People/adilger/
> http://sourceforge.net/projects/ext2resize/
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Ext2-devel mailing list
> Ext2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ext2-devel
next prev parent reply other threads:[~2002-09-28 19:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-25 20:03 [BK PATCH] Add ext3 indexed directory (htree) support tytso
2002-09-25 20:34 ` Andreas Dilger
2002-09-25 20:41 ` Dave Jones
2002-09-25 21:08 ` Andreas Dilger
2002-09-25 21:34 ` Theodore Ts'o
2002-09-25 22:54 ` Jeff Garzik
2002-09-25 23:29 ` Theodore Ts'o
2002-09-25 23:45 ` Ryan Cumming
2002-09-26 3:27 ` Theodore Ts'o
2002-09-26 5:23 ` Ryan Cumming
2002-09-26 5:57 ` Theodore Ts'o
2002-09-26 6:22 ` Ryan Cumming
2002-09-26 14:05 ` Theodore Ts'o
2002-09-26 6:25 ` Ryan Cumming
2002-09-26 11:25 ` Daniel Egger
2002-09-26 7:41 ` Ryan Cumming
2002-09-26 13:23 ` Theodore Ts'o
2002-09-26 15:42 ` Theodore Ts'o
2002-09-26 19:08 ` Ryan Cumming
2002-09-26 19:51 ` Horst von Brand
2002-09-26 19:59 ` Ryan Cumming
2002-09-26 22:04 ` Theodore Ts'o
2002-09-26 22:53 ` Ryan Cumming
2002-09-26 23:57 ` Theodore Ts'o
2002-09-27 1:00 ` Ryan Cumming
2002-09-27 3:24 ` Theodore Ts'o
2002-09-27 4:12 ` Andreas Dilger
2002-09-27 7:55 ` Ryan Cumming
2002-09-28 1:20 ` Ryan Cumming
2002-09-28 1:46 ` Ryan Cumming
2002-09-28 14:13 ` Theodore Ts'o
2002-09-28 14:18 ` Theodore Ts'o
2002-09-28 22:35 ` Ryan Cumming
2002-09-28 17:27 ` [Ext2-devel] " Andreas Dilger
2002-09-28 18:43 ` chrisl
2002-09-28 19:45 ` chrisl [this message]
2002-09-28 22:30 ` Ryan Cumming
2002-09-29 7:03 ` [PATCH] fix htree dir corrupt after fsck -fD chrisl
2002-09-29 8:16 ` Ryan Cumming
2002-09-29 8:36 ` Ryan Cumming
2002-09-30 2:46 ` Ryan Cumming
2002-09-29 14:13 ` Theodore Ts'o
2002-09-25 23:31 ` [BK PATCH] Add ext3 indexed directory (htree) support Daniel Egger
2002-09-26 0:32 ` Randy.Dunlap
2002-09-26 0:50 ` Aaron Lehmann
2002-09-26 3:28 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020928194513.GA1254@vmware.com \
--to=chrisl@gnuchina.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ryan@completely.kicks-ass.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).