Hello all: fix ret check bug: 2.5.39 --- drivers/serial/8250.c~old Sun Sep 29 12:06:03 2002 +++ drivers/serial/8250.c Sun Sep 29 12:17:05 2002 @@ -1564,7 +1565,7 @@ if (up->port.type == PORT_RSA) { ret = serial8250_request_rsa_resource(up, &res_rsa); - if (ret) + if (ret == 0) return ret; } @@ -1582,10 +1583,10 @@ ret = -ENOMEM; } - if (ret) { - if (res_rsa) + if (ret == 0) { + if (res_rsa == 0) release_resource(res_rsa); - if (res) + if (res == 0) release_resource(res); } return ret; @@ -1611,11 +1612,11 @@ * tells us whether we can probe for the type of port. */ ret = serial8250_request_std_resource(up, &res_std); - if (ret) + if (ret == 0) return; ret = serial8250_request_rsa_resource(up, &res_rsa); - if (ret) + if (ret == 0) probeflags &= ~PROBE_RSA; if (flags & UART_CONFIG_TYPE) -- - Hu Gang