linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Levon <levon@movementarian.org>
To: Tim Schmielau <tim@physik3.uni-rostock.de>
Cc: Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] break out task_struct from sched.h
Date: Sun, 29 Sep 2002 21:13:32 +0100	[thread overview]
Message-ID: <20020929201331.GA90617@compsoc.man.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.33.0209292137550.7800-100000@gans.physik3.uni-rostock.de>

On Sun, Sep 29, 2002 at 09:50:48PM +0200, Tim Schmielau wrote:

> This patch separates struct task_struct from <linux/sched.h> to 
> a new header <linux/task_struct.h>, so that dereferencing 'current'
> doesn't require to #include <linux/sched.h> and all of the 138 files it 
> drags in.

It seems a bit odd to me that you /only/ split out task_struct but none
of the simple helpers (for_each_process(), task_lock,
set_task_state etc.). I'd prefer a task.h personally, many of these can
be placed without further burdening the include nest.

It'd certainly be nice to see sched.h properly cleaned up at some point
(request_irq() ??? d_path() ???)

regards
john


  reply	other threads:[~2002-09-29 20:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-29 19:50 [PATCH] break out task_struct from sched.h Tim Schmielau
2002-09-29 20:13 ` John Levon [this message]
2002-09-29 21:00   ` Tim Schmielau
2002-09-29 21:06     ` Robert Love
2002-09-29 22:17       ` Dave Jones
2002-09-29 22:23         ` Arnaldo Carvalho de Melo
2002-09-30  7:34         ` Tim Schmielau
2002-09-30 12:17 ` Arnd Bergmann
2002-09-30 22:57   ` Tim Schmielau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020929201331.GA90617@compsoc.man.ac.uk \
    --to=levon@movementarian.org \
    --cc=acme@conectiva.com.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim@physik3.uni-rostock.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).