From: Arnd Bergmann <firstname.lastname@example.org>
To: Tim Schmielau <email@example.com>, firstname.lastname@example.org
Subject: Re: [PATCH] break out task_struct from sched.h
Date: Mon, 30 Sep 2002 14:17:40 +0200 [thread overview]
Message-ID: <200209301216.g8UCGj6g053616@d12relay01.de.ibm.com> (raw)
Tim Schmielau wrote:
> This patch separates struct task_struct from <linux/sched.h> to
> a new header <linux/task_struct.h>, so that dereferencing 'current'
> doesn't require to #include <linux/sched.h> and all of the 138 files it
> drags in.
> This is a preparatory step (and currently part of) the patch to remove
> 614 superfluous #includes of <linux/sched.h> at
I tried something similar before: I seperated out mm_struct from sched.h
so that mm.h does not have to include sched.h any more. At that time,
the results were poor, because most of the files that include mm.h but
not sched.h actually need 'current' or something else from sched.h
and I then had to include sched.h by hand in them.
With your work, it probably makes sense to look into this again.
Note that 241 of your 614 files that don't need sched.h still include
it through either linux/mm.h or linux/interrupt.h, so don't gain anything
There are some other headers that are critical as well (e.g.
pci.h->device.h->sched.h), but afaics mm.h and interrupt.h are the most
next prev parent reply other threads:[~2002-09-30 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 19:50 [PATCH] break out task_struct from sched.h Tim Schmielau
2002-09-29 20:13 ` John Levon
2002-09-29 21:00 ` Tim Schmielau
2002-09-29 21:06 ` Robert Love
2002-09-29 22:17 ` Dave Jones
2002-09-29 22:23 ` Arnaldo Carvalho de Melo
2002-09-30 7:34 ` Tim Schmielau
2002-09-30 12:17 ` Arnd Bergmann [this message]
2002-09-30 22:57 ` Tim Schmielau
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).