From: Dave Jones <davej@codemonkey.org.uk>
To: Matthew Dobson <colpatch@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
Martin Bligh <mjbligh@us.ibm.com>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [patch][rfc] xquad_portio cleanup
Date: Tue, 1 Oct 2002 16:21:48 +0100 [thread overview]
Message-ID: <20021001152148.GA126@suse.de> (raw)
In-Reply-To: <3D98DFA0.6020908@us.ibm.com>
On Mon, Sep 30, 2002 at 04:34:56PM -0700, Matthew Dobson wrote:
> diff -Nur linux-2.5.31-vanilla/arch/i386/boot/compressed/misc.c linux-2.5.31-xquad/arch/i386/boot/compressed/misc.c
> --- linux-2.5.31-vanilla/arch/i386/boot/compressed/misc.c Sat Aug 10 18:41:40 2002
> +++ linux-2.5.31-xquad/arch/i386/boot/compressed/misc.c Thu Aug 15 14:28:33 2002
> @@ -9,6 +9,8 @@
> * High loaded stuff by Hans Lermen & Werner Almesberger, Feb. 1996
> */
>
> +#define STANDALONE
...
> diff -Nur linux-2.5.31-vanilla/include/asm-i386/io.h linux-2.5.31-xquad/include/asm-i386/io.h
> --- linux-2.5.31-vanilla/include/asm-i386/io.h Sat Aug 10 18:41:28 2002
> +++ linux-2.5.31-xquad/include/asm-i386/io.h Thu Aug 15 15:17:31 2002
> @@ -298,7 +298,11 @@
> #endif
>
> #ifdef CONFIG_MULTIQUAD
> -extern void *xquad_portio; /* Where the IO area was mapped */
> + #ifdef STANDALONE
> + #define xquad_portio 0
> + #else /* !STANDALONE */
> + extern void *xquad_portio; /* Where the IO area was mapped */
> + #endif /* STANDALONE */
> #endif /* CONFIG_MULTIQUAD */
STANDALONE seems to be a very namespace-polluting choice of define.
MULTIQUAD_STANDALONE, MQ_STANDALONE... anything would be better imo.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
next prev parent reply other threads:[~2002-10-01 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-30 23:34 [patch][rfc] xquad_portio cleanup Matthew Dobson
2002-10-01 15:21 ` Dave Jones [this message]
2002-10-01 21:44 ` Matthew Dobson
2002-10-02 0:43 ` Alan Cox
2002-10-02 18:16 ` [patch][rfc] xquad_portio cleanup 2.5.40 Matthew Dobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021001152148.GA126@suse.de \
--to=davej@codemonkey.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjbligh@us.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).