From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@digeo.com>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: Shared memory shmat/dt not working well in
Date: Tue, 1 Oct 2002 19:56:07 +0200 [thread overview]
Message-ID: <20021001175607.GA1964@vana.vc.cvut.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0210011804001.1783-100000@localhost.localdomain>
On Tue, Oct 01, 2002 at 06:14:04PM +0100, Hugh Dickins wrote:
> On Tue, 1 Oct 2002, Petr Vandrovec wrote:
> >
> > You are my hero!
>
> Aww, shucks! I guess I'd better have a go at your next problem...
>
> Looks to me like flush_tlb_mm is faulting on the vma->vm_mm given it.
> And looks to me like mprotect_fixup, in the merge case, may be passing
> an already freed vma to change_protection. I'm not as confident about
> this patch as the earlier one, but I believe it's correct: please
> give it a try, and maybe Christoph will confirm or deny it.
Thanks. It fixed my problem (again ;-) ). Maybe I should already asked
yesterday instead of starring at mprotect code.
Many thanks,
Petr Vandrovec
vandrove@vc.cvut.cz
> Hugh
>
> --- 2.5.40/mm/mprotect.c Fri Sep 27 23:56:45 2002
> +++ linux/mm/mprotect.c Tue Oct 1 18:00:31 2002
> @@ -186,8 +186,10 @@
> /*
> * Try to merge with the previous vma.
> */
> - if (mprotect_attempt_merge(vma, *pprev, end, newflags))
> + if (mprotect_attempt_merge(vma, *pprev, end, newflags)) {
> + vma = *pprev;
> goto success;
> + }
> } else {
> error = split_vma(mm, vma, start, 1);
> if (error)
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2002-10-01 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-01 16:02 [PATCH] Re: Shared memory shmat/dt not working well in Petr Vandrovec
2002-10-01 17:14 ` Hugh Dickins
2002-10-01 17:56 ` Petr Vandrovec [this message]
2002-10-01 19:01 ` Christoph Hellwig
2002-10-01 19:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021001175607.GA1964@vana.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=akpm@digeo.com \
--cc=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).