* [PATCH] default file permission for vfat
@ 2002-10-01 17:39 Miroslav Rudisin
2002-10-01 18:55 ` Willy Tarreau
0 siblings, 1 reply; 6+ messages in thread
From: Miroslav Rudisin @ 2002-10-01 17:39 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
Hi,
The attached patch change default permission of files on [v]fatfs.
Default RWX have no utilization. This patch remove exec flag.
2.4.19 & 2.5.30
Thanks
--
Miroslav Rudisin
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 462 bytes --]
--- inode.c.orig Mon Aug 5 21:56:01 2002
+++ inode.c Mon Aug 5 21:58:32 2002
@@ -932,8 +932,8 @@
inode->i_generation |= 1;
inode->i_mode = MSDOS_MKMODE(de->attr,
((sbi->options.showexec &&
- !is_exec(de->ext))
- ? S_IRUGO|S_IWUGO : S_IRWXUGO)
+ is_exec(de->ext))
+ ? S_IRWXUGO : S_IRUGO|S_IWUGO)
& ~sbi->options.fs_umask) | S_IFREG;
MSDOS_I(inode)->i_start = CF_LE_W(de->start);
if (sbi->fat_bits == 32) {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] default file permission for vfat
2002-10-01 17:39 [PATCH] default file permission for vfat Miroslav Rudisin
@ 2002-10-01 18:55 ` Willy Tarreau
2002-10-02 9:02 ` Padraig Brady
0 siblings, 1 reply; 6+ messages in thread
From: Willy Tarreau @ 2002-10-01 18:55 UTC (permalink / raw)
To: Miroslav Rudisin; +Cc: linux-kernel
On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
> Hi,
>
> The attached patch change default permission of files on [v]fatfs.
> Default RWX have no utilization. This patch remove exec flag.
Hi !
This is sometimes very useful to put init scripts on a floppy disk. I'd
prefer to keep exec flags. If you don't want files to be executable, you
still can mount the FS with the 'noexec' option.
Cheers,
Willy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] default file permission for vfat
2002-10-01 18:55 ` Willy Tarreau
@ 2002-10-02 9:02 ` Padraig Brady
2002-10-02 9:46 ` Willy Tarreau
0 siblings, 1 reply; 6+ messages in thread
From: Padraig Brady @ 2002-10-02 9:02 UTC (permalink / raw)
To: Willy Tarreau; +Cc: Miroslav Rudisin, linux-kernel
Willy Tarreau wrote:
> On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
>
>>Hi,
>>
>>The attached patch change default permission of files on [v]fatfs.
>>Default RWX have no utilization. This patch remove exec flag.
>
> Hi !
>
> This is sometimes very useful to put init scripts on a floppy disk.
Not the common case and you can use different format floppies for this anyway.
> I'd prefer to keep exec flags. If you don't want files to be executable, you
> still can mount the FS with the 'noexec' option.
Not since: http://www.uwsg.iu.edu/hypermail/linux/kernel/0109.3/0363.html
Ideal would be to have a umask and dmask option (that applied to everything
not just vfat)
See also: http://kt.zork.net/kernel-traffic/kt20020415_162.html#1
Pádraig.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] default file permission for vfat
2002-10-02 9:02 ` Padraig Brady
@ 2002-10-02 9:46 ` Willy Tarreau
2002-10-02 10:38 ` GOMBAS Gabor
0 siblings, 1 reply; 6+ messages in thread
From: Willy Tarreau @ 2002-10-02 9:46 UTC (permalink / raw)
To: Padraig Brady; +Cc: Willy Tarreau, Miroslav Rudisin, linux-kernel
On Wed, Oct 02, 2002 at 10:02:48AM +0100, Padraig Brady wrote:
> Willy Tarreau wrote:
> >On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
> >
> >>Hi,
> >>
> >>The attached patch change default permission of files on [v]fatfs.
> >>Default RWX have no utilization. This patch remove exec flag.
> >
> >Hi !
> >
> >This is sometimes very useful to put init scripts on a floppy disk.
>
> Not the common case and you can use different format floppies for this
> anyway.
not when you want your customers to be able to edit their firewall config
with their M$ PC !
Willy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] default file permission for vfat
2002-10-02 9:46 ` Willy Tarreau
@ 2002-10-02 10:38 ` GOMBAS Gabor
0 siblings, 0 replies; 6+ messages in thread
From: GOMBAS Gabor @ 2002-10-02 10:38 UTC (permalink / raw)
To: linux-kernel
On Wed, Oct 02, 2002 at 11:46:12AM +0200, Willy Tarreau wrote:
> not when you want your customers to be able to edit their firewall config
> with their M$ PC !
Copy them to tmpfs, do "chmod +x", execute them.
Gabor
--
Gabor Gombas Eotvos Lorand University
E-mail: gombasg@inf.elte.hu Hungary
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] default file permission for vfat
@ 2002-10-02 20:52 Stas Sergeev
0 siblings, 0 replies; 6+ messages in thread
From: Stas Sergeev @ 2002-10-02 20:52 UTC (permalink / raw)
To: linux-kernel; +Cc: miero
Hello.
Miroslav Rudisin wrote:
> The attached patch change default permission of files on [v]fatfs.
> Default RWX have no utilization. This patch remove exec flag.
Thank you very much!
Since the "noexec" option was broken, this
patch is extremely usefull.
I would like to see it included, but, as I
don't know the details, I pretend to say nothing
except that it is very usefull for me.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-10-02 20:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-01 17:39 [PATCH] default file permission for vfat Miroslav Rudisin
2002-10-01 18:55 ` Willy Tarreau
2002-10-02 9:02 ` Padraig Brady
2002-10-02 9:46 ` Willy Tarreau
2002-10-02 10:38 ` GOMBAS Gabor
2002-10-02 20:52 Stas Sergeev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).