From: Andrea Arcangeli <andrea@suse.de>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.20pre8aa2
Date: Thu, 3 Oct 2002 00:12:04 +0200 [thread overview]
Message-ID: <20021002221204.GK1567@dualathlon.random> (raw)
In-Reply-To: <20021002214540.GA2589@werewolf.able.es>
On Wed, Oct 02, 2002 at 11:45:40PM +0200, J.A. Magallon wrote:
>
> On 2002.10.02 Andrea Arcangeli wrote:
> >URL:
> >
> > http://www.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.20pre8aa2.gz
> > http://www.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.20pre8aa2/
> >
> >Changelog between 2.4.20pre8aa1 and 2.4.20pre8aa2:
> >
>
> I was rediffing the task_cpu patch, when reached a new hunk in -aa:
>
> kernel/sched.c::sched_init(void):
>
> + current->cpu = smp_processor_id();
>
> As include/asm-i386/smp.h says,
>
> #define smp_processor_id() (current->cpu)
>
> So you have a harmless and useless assignment...
> unless you really wanted to do any other thing, or
> smp_processor_id() != current->cpu in some arch.
yes, it's a superflous line, it's the equivalent of the 2.5.40 line
here:
rq->idle = current;
set_task_cpu(current, smp_processor_id());
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
wake_up_process(current);
it is a superflous bit in the o1 scheduler changes. If the boot cpu
isn't id 0 it must be initialized by the architectural code in arch/.
Either that or sched_init must use hard_smp_processor_id(). On most
archs the boot cpu is id 0 so it probably doesn't trigger if needed.
Andrea
next prev parent reply other threads:[~2002-10-02 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-02 7:11 2.4.20pre8aa2 Andrea Arcangeli
2002-10-02 21:45 ` 2.4.20pre8aa2 J.A. Magallon
2002-10-02 22:12 ` Andrea Arcangeli [this message]
2002-10-02 22:18 ` 2.4.20pre8aa2 Robert Love
2002-10-02 23:30 ` 2.4.20pre8aa2 - i8k compile failure Eyal Lebedinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021002221204.GK1567@dualathlon.random \
--to=andrea@suse.de \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).