archive mirror
 help / color / mirror / Atom feed
From: Greg KH <>
To: Martin Diehl <>
Subject: Re: calling context when writing to tty_driver
Date: Wed, 2 Oct 2002 23:52:09 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <Pine.LNX.4.21.0210012150300.485-100000@notebook.diehl.home>

On Tue, Oct 01, 2002 at 11:10:34PM +0200, Martin Diehl wrote:
> Another question/suggestion: do we need to acquire port->sem in usbserial?
> Couldn't this be done with a spinlock - at least when called from_user?

It used to be a spinlock, but too many drivers did bad things with the
spinlock held, so I changed it to a semaphore so they could sleep while
it is held.  I think in 2.5, all of the nasty drivers can be easily
fixed (the usb core now can be told not to sleep when submitting an
urb), so this might be able to be changed back to a spinlock.

> If we agree serial drivers shouldn't sleep in write_room()/write() my
> impression is this needs to be addressed somehow, regardless whether
> usbserial uses the new serial core or not. Anybody tried this with a
> bluetooth dongle over usbserial?

I don't know, do we agree that you can't sleep in those functions?  If
so, I'll look into fixing the usbserial drivers up.


greg k-h

  reply	other threads:[~2002-10-03  6:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-01 10:37 calling context when writing to tty_driver Martin Diehl
2002-10-01 11:13 ` David McIlwraith
2002-10-01 11:28   ` Martin Diehl
2002-10-01 11:32     ` David McIlwraith
2002-10-01 18:34 ` Greg KH
2002-10-01 19:30   ` Russell King
2002-10-01 21:10   ` Martin Diehl
2002-10-03  6:52     ` Greg KH [this message]
2002-10-03  9:51       ` Paul Mackerras
2002-10-03 21:36         ` Martin Diehl
2002-10-01 23:20   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).