From: Mikael Pettersson <mikpe@csd.uu.se>
To: linux-kernel@vger.kernel.org, tmolina@cox.net
Cc: mec@shout.net
Subject: Re: 2.5.40: problem with configuration system
Date: Mon, 7 Oct 2002 00:26:47 +0200 (MET DST) [thread overview]
Message-ID: <200210062226.AAA10733@harpo.it.uu.se> (raw)
On Sun, 6 Oct 2002 16:28:09 -0500 (CDT), Thomas Molina wrote:
>I was configuring a kernel for a rescue disk, so lots of things were not
>configured that normally would be. At the end of the compile I get:
>
>arch/i386/kernel/built-in.o: In function `MP_processor_info':
>arch/i386/kernel/built-in.o(.text.init+0x31ab): undefined reference to
>`Dprintk'
...
># CONFIG_DEBUG_KERNEL is not set
>CONFIG_X86_EXTRA_IRQS=y
>CONFIG_X86_FIND_SMP_CONFIG=y
>CONFIG_X86_MPPARSE=y
>
>The thing I don't understand is why they should be set to y. My
>understanding from reading the source is that they should only be y if
>CONFIG_X86_LOCAL_APIC is y. That should only happen if CONFIG_SMP is not
>y and CONFIG_X86_UP_APIC is y. The enclosed .config file shows this isn't
>the case. What am I missing?
This happened to me recently when I copied a .config which had
UP_APIC=y and used make config to disable UP_APIC. The problem in
my case was that the good ole' Configure script doesn't always
reach a fixpoint in one iteration: the fact that LOCAL_APIC=y at the
start is sufficient for it to emit MPPARSE=y at the end, even though
LOCAL_APIC got disabled. A 'make oldconfig' should fix the situation.
This is not the only case where Configure gets it wrong. There is
a bug involving dep_tristate, forward dependencies, and toggling
module support which I reported to LKML ages ago (with a fix), but
nobody cared so... FWIW, the fix to that bug is included below.
/Mikael
--- linux-2.5.40/scripts/Configure.~1~ Thu Oct 3 00:00:00 2002
+++ linux-2.5.40/scripts/Configure Thu Oct 3 18:32:20 2002
@@ -316,7 +316,13 @@
return
;;
m)
- need_module=1
+ # Note: "m" means "module" only when CONFIG_MODULES=y,
+ # otherwise it really means "y". This matters when
+ # a dep_tristate dependency is a forward reference
+ # which we haven't yet "corrected" from "m" to "y".
+ if [ "$CONFIG_MODULES" = "y" ]; then
+ need_module=1
+ fi
;;
esac
shift
next reply other threads:[~2002-10-06 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-06 22:26 Mikael Pettersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-10-06 21:28 2.5.40: problem with configuration system Thomas Molina
2002-10-06 22:02 ` Andrew Morton
2002-10-06 23:02 ` Thomas Molina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210062226.AAA10733@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=mec@shout.net \
--cc=tmolina@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).