[PATCH] 2.4: get_pid() typo fix

[PATCH] 2.4: get_pid() typo fix

[Robert Love]

Magnificent Marcelo,

Fix a typo in the comment of getpid() - we return current->tgid these
days, not current->pid.  Additionally, add some new comments explaining
exactly why we return the tgid and how this works.

Patch is against 2.4.20-pre9, please apply.

	Robert Love

diff -urN linux-2.4.20-pre9/kernel/timer.c linux/kernel/timer.c
--- linux-2.4.20-pre9/kernel/timer.c	2002-10-06 14:57:20.000000000 -0400
+++ linux/kernel/timer.c	2002-10-06 15:03:31.000000000 -0400
@@ -740,10 +740,18 @@
  * The Alpha uses getxpid, getxuid, and getxgid instead.  Maybe this
  * should be moved into arch/i386 instead?
  */
- 
+
+/**
+ * sys_getpid - return the thread group id of the current process
+ *
+ * Note, despite the name, this returns the tgid not the pid.  The tgid and
+ * the pid are identical unless CLONE_THREAD was specified on clone() in
+ * which case the tgid is the same in all threads of the same group.
+ *
+ * This is SMP safe as current->tgid does not change.
+ */
 asmlinkage long sys_getpid(void)
 {
-	/* This is SMP safe - current->pid doesn't change */
 	return current->tgid;
 }
 

Re: [PATCH] 2.4: get_pid() typo fix

[Denis Vlasenko]

On 6 October 2002 17:44, Robert Love wrote:
> Magnificent Marcelo,
  ^^^^^^^^^^^
Is this affects probability of patch being accepted?
If yes, which is the best? ;-)
--
vda