From: Pavel Machek <pavel@ucw.cz>
To: William Lee Irwin III <wli@holomorphy.com>,
Adrian Bunk <bunk@fs.tum.de>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux v2.5.41
Date: Tue, 8 Oct 2002 22:28:45 +0200 [thread overview]
Message-ID: <20021008222845.C296@elf.ucw.cz> (raw)
In-Reply-To: <20021008134107.GH12432@holomorphy.com>
Hi!
> > This change causes the following compile error with CONFIG_DISCONTIGMEM
> > enabled:
> > kernel/suspend.c: In function `count_and_copy_data_pages':
> > kernel/suspend.c:479: `max_mapnr' undeclared (first use in this function)
> > kernel/suspend.c:479: (Each undeclared identifier is reported only once
> > kernel/suspend.c:479: for each function it appears in.)
> > make[1]: *** [kernel/suspend.o] Error 1
> > make: *** [kernel] Error 2
>
> max_mapnr must die. It's mostly buggy largely because it's not what
> people think it is. Most of the time people want max_pfn, and the rest
> they don't want it at all.
It seems more logical now.
> Pavel, you might also want to make config options conflict instead of
> panicking.
Actually, I think I prefer panic(). That way it will be less broken
when someone will try to fix discontigmem.
> diff -urN linux-2.5.41/kernel/suspend.c swsusp-2.5.41/kernel/suspend.c
> --- linux-2.5.41/kernel/suspend.c 2002-10-07 11:23:37.000000000 -0700
> +++ swsusp-2.5.41/kernel/suspend.c 2002-10-08 06:16:54.000000000 -0700
> @@ -474,9 +474,9 @@
> #ifdef CONFIG_DISCONTIGMEM
> panic("Discontingmem not supported");
> #else
> - BUG_ON (max_mapnr != num_physpages);
> + BUG_ON (max_pfn != num_physpages);
> #endif
> - for (pfn = 0; pfn < max_mapnr; pfn++) {
> + for (pfn = 0; pfn < max_pfn; pfn++) {
> page = pfn_to_page(pfn);
> if (PageHighMem(page))
> panic("Swsusp not supported on highmem boxes. Send 1GB of RAM to <pavel@ucw.cz> and try again ;-).");
Applied.
Pavel
--
When do you have heart between your knees?
next prev parent reply other threads:[~2002-10-08 20:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-07 19:02 Linux v2.5.41 Linus Torvalds
2002-10-07 19:22 ` Linus Torvalds
2002-10-07 19:29 ` Robert Love
2002-10-07 20:32 ` Linux v2.5.41 -> don't compil Gregoire Favre
2002-10-07 21:03 ` [PATCH] Fix IPv6 [was Re: Linux v2.5.41] Jasper Spaans
2002-10-08 1:08 ` [PATCH] Fix IPv6 YOSHIFUJI Hideaki / 吉藤英明
2002-10-08 1:26 ` kuznet
2002-10-08 19:51 ` David S. Miller
2002-10-08 12:02 ` Linux v2.5.41 Adrian Bunk
2002-10-08 13:41 ` William Lee Irwin III
2002-10-08 20:28 ` Pavel Machek [this message]
[not found] <mailman.1034018941.1657.linux-kernel2news@redhat.com>
2002-10-07 20:01 ` Pete Zaitcev
2002-10-07 19:57 ` David S. Miller
2002-10-07 20:03 ` Vojtech Pavlik
2002-10-07 20:01 ` David S. Miller
2002-10-07 20:08 ` Vojtech Pavlik
2002-10-07 20:28 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021008222845.C296@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).