From: DervishD <raul@pleyades.net>
To: Linux-kernel <linux-kernel@vger.kernel.org>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: [PATCH] mmap.c (do_mmap_pgoff), against 2.4.19 and 2.4.20-pre10
Date: Mon, 14 Oct 2002 11:36:22 +0200 [thread overview]
Message-ID: <20021014093622.GA96@DervishD> (raw)
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Hi all, specially Marcelo :)
This is the fourth and last time I submit this patch to Marcelo.
This little tiny bug is fixed in all trees except the official one. I
think this patch is trivial enough to be accepted, but...
Well, the attachments included (unified diff format), is the patch
against both 2.4.19 and 2.4.20-pre10 (I've changed the kernel name
directory part to '/usr/src/linux/' so it's applicable to both
versions.
Marcelo, if you don't want to include this patch at least let me
know, please, so I won't need to see each new prerelease for seeing
if the patch has been already included ;))) Don't take it bad.
Raúl
[-- Attachment #2: mmap.c.diff --]
[-- Type: text/plain, Size: 824 bytes --]
--- /usr/src/linux/mm/mmap.c.orig 2002-10-14 11:16:40.000000000 +0200
+++ /usr/src/linux/kernel/mm/mmap.c 2002-10-14 11:19:32.000000000 +0200
@@ -390,6 +390,12 @@
return 0;
}
+
+/*
+ * NOTE: in this function we rely on TASK_SIZE being lower than
+ * SIZE_MAX-PAGE_SIZE at least. I'm pretty sure that it is.
+ */
+
unsigned long do_mmap_pgoff(struct file * file, unsigned long addr, unsigned long len,
unsigned long prot, unsigned long flags, unsigned long pgoff)
{
@@ -403,12 +409,14 @@
if (file && (!file->f_op || !file->f_op->mmap))
return -ENODEV;
- if ((len = PAGE_ALIGN(len)) == 0)
+ if (!len)
return addr;
if (len > TASK_SIZE)
return -EINVAL;
+ len = PAGE_ALIGN(len); /* This cannot be zero now */
+
/* offset overflow? */
if ((pgoff + (len >> PAGE_SHIFT)) < pgoff)
return -EINVAL;
next reply other threads:[~2002-10-14 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-14 9:36 DervishD [this message]
2002-10-14 9:52 ` [PATCH] mmap.c (do_mmap_pgoff), against 2.4.19 and 2.4.20-pre10 David S. Miller
2002-10-14 10:20 ` DervishD
2002-10-14 10:44 ` David S. Miller
2002-10-14 11:04 ` DervishD
2002-10-14 10:09 ` Russell King
2002-10-14 10:25 ` DervishD
2002-10-14 20:26 ` Marcelo Tosatti
2002-10-15 7:37 ` DervishD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021014093622.GA96@DervishD \
--to=raul@pleyades.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).