From: Andreas Dilger <adilger@clusterfs.com>
To: Andrew Morton <akpm@digeo.com>
Cc: tytso@mit.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Add extended attributes to ext2/3
Date: Mon, 14 Oct 2002 23:31:18 -0600 [thread overview]
Message-ID: <20021015053118.GA15552@clusterfs.com> (raw)
In-Reply-To: <3DAB9DA5.42008138@digeo.com>
On Oct 14, 2002 21:46 -0700, Andrew Morton wrote:
> btw, gcc-2.91.66 is saying:
>
> fs/ext2/xattr.c: In function `ext2_xattr_set':
> fs/ext2/xattr.c:612: warning: `block' might be used uninitialized in this function
>
> But the code is:
>
> int block = EXT2_I(inode)->i_file_acl;
>
> which is rather bizarre. Never seen it do that before.
There's a "goto bad_block" in that function, and it enters _after_
block is set (block is a local variable), so it is impossible for
it to have a valid value.
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
next prev parent reply other threads:[~2002-10-15 5:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-15 3:33 [PATCH 1/4] Add extended attributes to ext2/3 tytso
2002-10-15 4:46 ` Andrew Morton
2002-10-15 5:04 ` Theodore Ts'o
2002-10-15 5:31 ` Andreas Dilger [this message]
2002-10-15 13:05 ` Theodore Ts'o
2002-10-15 10:26 ` Olaf Dietsche
2002-10-15 11:58 ` Christoph Hellwig
2002-10-15 13:15 ` Theodore Ts'o
2002-10-15 15:25 ` Christoph Hellwig
2002-10-15 15:31 ` Christoph Hellwig
2002-10-15 16:04 ` Andreas Dilger
2002-10-15 16:16 ` Christoph Hellwig
2002-10-15 16:21 ` Andreas Dilger
2002-10-15 16:43 ` Andreas Gruenbacher
2002-10-15 16:41 ` Theodore Ts'o
2002-10-15 16:59 ` Christoph Hellwig
2002-10-15 15:33 ` Christoph Hellwig
2002-10-15 15:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021015053118.GA15552@clusterfs.com \
--to=adilger@clusterfs.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).