From: Rusty Russell <rusty@rustcorp.com.au>
To: Ravikiran G Thirumalai <kiran@in.ibm.com>
Cc: akpm@zip.com.au, dipankar@in.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] kmalloc_percpu
Date: Fri, 1 Nov 2002 19:33:54 +1100 [thread overview]
Message-ID: <20021101193354.54367ba4.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20021031213640.D2298@in.ibm.com>
On Thu, 31 Oct 2002 21:36:40 +0530
Ravikiran G Thirumalai <kiran@in.ibm.com> wrote:
> Here's kmalloc_percpu interfaces ported (...mostly rediffed) to
> 2.5.45. (One last try for 2.6).
IMHO this is a "when we need it" patch. Baby steps...
> +#define this_cpu_ptr(ptr) per_cpu_ptr(ptr, smp_processor_id())
Probably want a get_cpu_ptr() & put_cpu_ptr() using get_cpu() and put_cpu()
(and this would become __get_cpu_ptr()).
And probably move them all to linux/percpu.h.
> +extern void *kmalloc_percpu(size_t size, int flags);
> +extern void kfree_percpu(const void *);
> +extern int percpu_interlaced_alloc(struct percpu_data *, size_t, int);
> +extern void percpu_interlaced_free(struct percpu_data *);
> +extern void percpu_data_sys_init(void);
Hmm... It'd be nice to remove these three from the header so that the
interface is clear (which may mean exposing some slab.c internals so
you can access them in mm/percpu_data.c).
> + if(!blklist->cachep)
A space between the "if" and the "(" is traditional.
Cheers,
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
next prev parent reply other threads:[~2002-11-01 8:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-31 16:06 [patch] kmalloc_percpu Ravikiran G Thirumalai
2002-11-01 8:33 ` Rusty Russell [this message]
2002-11-05 16:00 ` Dipankar Sarma
2003-05-05 8:08 [PATCH] kmalloc_percpu Rusty Russell
2003-05-05 8:47 ` Andrew Morton
2003-05-06 0:47 ` Rusty Russell
2003-05-06 1:52 ` Andrew Morton
2003-05-06 2:11 ` David S. Miller
2003-05-06 4:08 ` Rusty Russell
2003-05-06 3:40 ` David S. Miller
2003-05-06 5:02 ` Andrew Morton
2003-05-06 4:16 ` David S. Miller
2003-05-06 5:48 ` Andrew Morton
2003-05-06 5:35 ` David S. Miller
2003-05-06 6:55 ` Andrew Morton
2003-05-06 5:57 ` David S. Miller
2003-05-06 7:22 ` Andrew Morton
2003-05-06 6:15 ` David S. Miller
2003-05-06 7:34 ` Andrew Morton
2003-05-06 8:42 ` William Lee Irwin III
2003-05-06 14:38 ` Martin J. Bligh
2003-05-06 7:20 ` Dipankar Sarma
2003-05-06 8:28 ` Rusty Russell
2003-05-06 8:47 ` Andrew Morton
2003-05-07 1:57 ` Rusty Russell
2003-05-07 2:41 ` William Lee Irwin III
2003-05-07 4:03 ` Paul Mackerras
2003-05-07 4:22 ` William Lee Irwin III
2003-05-07 4:56 ` Paul Mackerras
2003-05-07 5:19 ` William Lee Irwin III
2003-05-07 4:10 ` Martin J. Bligh
2003-05-07 12:13 ` William Lee Irwin III
2003-05-07 4:15 ` Rusty Russell
2003-05-07 5:37 ` Andrew Morton
2003-05-08 0:53 ` Rusty Russell
2003-05-06 14:41 ` Martin J. Bligh
2003-05-06 6:42 ` Andrew Morton
2003-05-06 5:39 ` David S. Miller
2003-05-06 6:57 ` Andrew Morton
2003-05-06 7:25 ` Jens Axboe
2003-05-06 10:41 ` Ingo Oeser
2003-05-06 16:05 ` Bryan O'Sullivan
2003-05-06 8:06 ` Rusty Russell
2003-05-06 5:03 ` Dipankar Sarma
2003-05-06 4:28 ` Andrew Morton
2003-05-06 3:37 ` David S. Miller
2003-05-06 4:11 ` Rusty Russell
2003-05-06 5:07 ` Ravikiran G Thirumalai
2003-05-06 8:03 ` Rusty Russell
2003-05-06 9:23 ` David S. Miller
2003-05-06 9:34 ` Ravikiran G Thirumalai
2003-05-06 9:38 ` Dipankar Sarma
2003-05-07 2:14 ` Rusty Russell
2003-05-07 5:51 ` Ravikiran G Thirumalai
2003-05-07 6:16 ` Rusty Russell
2003-05-08 7:42 ` Ravikiran G Thirumalai
2003-05-08 7:47 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021101193354.54367ba4.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@zip.com.au \
--cc=dipankar@in.ibm.com \
--cc=kiran@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).