* [RFC][PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled
@ 2002-11-14 4:04 Shawn Starr
2002-11-14 22:59 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Starr @ 2002-11-14 4:04 UTC (permalink / raw)
To: linux-kernel
Hi, this should fix this compile problem (if this is correct).
Please apply.
Shawn.
diff -urpN linux-2.5.47-vanilla/drivers/acpi/sleep.c linux-2.5.47-fixes/drivers/acpi/sleep.c
--- linux-2.5.47-vanilla/drivers/acpi/sleep.c 2002-11-13 22:40:07.000000000 -0500
+++ linux-2.5.47-fixes/drivers/acpi/sleep.c 2002-11-13 22:55:25.000000000 -0500
@@ -205,8 +205,10 @@ acpi_system_suspend(
break;
case ACPI_STATE_S2:
+#ifdef CONFIG_SOFTWARE_SUSPEND
case ACPI_STATE_S3:
do_suspend_lowlevel(0);
+#endif
break;
}
local_irq_restore(flags);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled
2002-11-14 4:04 [RFC][PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled Shawn Starr
@ 2002-11-14 22:59 ` Pavel Machek
2002-11-16 5:12 ` Shawn Starr
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2002-11-14 22:59 UTC (permalink / raw)
To: Shawn Starr; +Cc: linux-kernel
Hi!
> Hi, this should fix this compile problem (if this is correct).
>
> Please apply.
It would silently do nothing, that's bad.
Could you make it so that CONFIG_ACPI_SLEEP is not selectable without
CONFIG_SOFTWARE_SUSPEND and move CONFIG_SOFTWARE_SUSPEND into "power
managment" submenu?
Pavel
> break;
>
> case ACPI_STATE_S2:
> +#ifdef CONFIG_SOFTWARE_SUSPEND
> case ACPI_STATE_S3:
> do_suspend_lowlevel(0);
> +#endif
> break;
> }
> local_irq_restore(flags);
>
>
--
When do you have heart between your knees?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled
2002-11-14 22:59 ` Pavel Machek
@ 2002-11-16 5:12 ` Shawn Starr
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Starr @ 2002-11-16 5:12 UTC (permalink / raw)
To: Pavel Machek; +Cc: linux-kernel
I can fix this, sure. I'll have a fix later today or so.
On November 14, 2002 05:59 pm, Pavel Machek wrote:
> Hi!
>
> > Hi, this should fix this compile problem (if this is correct).
> >
> > Please apply.
>
> It would silently do nothing, that's bad.
>
> Could you make it so that CONFIG_ACPI_SLEEP is not selectable without
> CONFIG_SOFTWARE_SUSPEND and move CONFIG_SOFTWARE_SUSPEND into "power
> managment" submenu?
> Pavel
>
> > break;
> >
> > case ACPI_STATE_S2:
> > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > case ACPI_STATE_S3:
> > do_suspend_lowlevel(0);
> > +#endif
> > break;
> > }
> > local_irq_restore(flags);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-11-16 5:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-14 4:04 [RFC][PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled Shawn Starr
2002-11-14 22:59 ` Pavel Machek
2002-11-16 5:12 ` Shawn Starr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).