From: Adrian Bunk <bunk@fs.tum.de>
To: Linus Torvalds <torvalds@transmeta.com>,
Dominik Brodowski <linux@brodo.de>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux v2.5.58
Date: Tue, 14 Jan 2003 08:55:35 +0100 [thread overview]
Message-ID: <20030114075535.GL21826@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0301132205550.6784-100000@penguin.transmeta.com>
On Mon, Jan 13, 2003 at 10:14:29PM -0800, Linus Torvalds wrote:
>...
> Summary of changes from v2.5.57 to v2.5.58
> ============================================
>...
> Dominik Brodowski <linux@brodo.de>:
>...
> o cpufreq: per-CPU initialization
>...
This change broke the compilation of several cpufreq drivers:
<-- snip -->
...
gcc -Wp,-MD,arch/i386/kernel/cpu/cpufreq/.powernow-k6.o.d -D__KERNEL__
-Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6 -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
-DKBUILD_BASENAME=powernow_k6 -DKBUILD_MODNAME=powernow_k6 -c -o
arch/i386/kernel/cpu/cpufreq/powernow-k6.o
arch/i386/kernel/cpu/cpufreq/powernow-k6.c
arch/i386/kernel/cpu/cpufreq/powernow-k6.c:230: macro
`cpufreq_unregister' used without args
make[3]: *** [arch/i386/kernel/cpu/cpufreq/powernow-k6.o] Error 1
<-- snip -->
It seems the following was intended:
--- linux-2.5.58/include/linux/cpufreq.h.old 2003-01-14 08:53:27.000000000 +0100
+++ linux-2.5.58/include/linux/cpufreq.h 2003-01-14 08:53:56.000000000 +0100
@@ -130,7 +130,7 @@
int cpufreq_unregister_driver(struct cpufreq_driver *driver_data);
/* deprecated */
#define cpufreq_register(x) cpufreq_register_driver(x)
-#define cpufreq_unregister(x) cpufreq_unregister_driver(NULL)
+#define cpufreq_unregister() cpufreq_unregister_driver(NULL)
void cpufreq_notify_transition(struct cpufreq_freqs *freqs, unsigned int state);
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2003-01-14 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-14 6:14 Linux v2.5.58 Linus Torvalds
2003-01-14 7:55 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030114075535.GL21826@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).