linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Stephen D. Smalley" <sds@epoch.ncsc.mil>
Cc: ak@muc.de, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-security-module@wirex.com,
	viro@math.psu.edu
Subject: Re: [RFC] Changes to the LSM file-related hooks for 2.5.58
Date: Wed, 15 Jan 2003 15:56:24 +0000	[thread overview]
Message-ID: <20030115155624.A15189@infradead.org> (raw)
In-Reply-To: <200301151544.KAA17539@moss-shockers.ncsc.mil>; from sds@epoch.ncsc.mil on Wed, Jan 15, 2003 at 10:44:52AM -0500

On Wed, Jan 15, 2003 at 10:44:52AM -0500, Stephen D. Smalley wrote:
> 
> "Andi Kleen" <ak@muc.de> writes:
> > Adding release_private_file requires fixing all code that uses 
> > init_private_file (including possible third party code). Otherwise
> > you have some subtle leak. It would better to rename init_private_file to
> > some other name and add appropiate comments so that this can be catched 
> > easily at compile time.
> 
> Thanks for the suggestion.  I've split out this logical change into a
> separate patch and reworked it in accordance with your suggestion.  See
> below.  Let me know if this does not address your concern.

Once you're at it please aqdd an argument to set file.f_flags so the
caller can set O_LARGEFILE properly.  The (unmerged) XFS dmapi code wants
that.


  reply	other threads:[~2003-01-15 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-15 15:44 [RFC] Changes to the LSM file-related hooks for 2.5.58 Stephen D. Smalley
2003-01-15 15:56 ` Christoph Hellwig [this message]
2003-01-15 16:04 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2003-01-15 20:49 Stephen D. Smalley
     [not found] <20030114191012$4fb6@gated-at.bofh.it>
2003-01-15  8:49 ` Andi Kleen
2003-01-14 19:08 Stephen D. Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030115155624.A15189@infradead.org \
    --to=hch@infradead.org \
    --cc=ak@muc.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@wirex.com \
    --cc=sds@epoch.ncsc.mil \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).