From: Pavel Machek <pavel@ucw.cz>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: sys32_ioctl -> compat_ioctl -- generic
Date: Fri, 7 Mar 2003 00:37:21 +0100 [thread overview]
Message-ID: <20030306233721.GA8565@elf.ucw.cz> (raw)
In-Reply-To: <20030305103619.52ccdfe2.sfr@canb.auug.org.au>
Hi!
> > +asmlinkage long compat_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg)
>
> For consistancy, this should be called compat_sys_ioctl.
Done. (And moved whole stuff to fs/compat.c).
> > +{
> > + struct file * filp;
>
> > + filp = fget(fd);
>
> > + /* find the name of the device. */
> > + if (path) {
> > + struct file *f = fget(fd);
>
> Is it really necessary to do another fget(fd) ?
This is andi's code, but it seems unneeded, fixed.
> Also, if you are adding this much code, you should add a copyright notice
> to the top of the file ...
I actually need to copy copyrights from ia32_ioctl, where I took
this. Done.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-03-09 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-03 23:21 sys32_ioctl -> compat_ioctl -- generic Pavel Machek
2003-03-04 23:28 ` Stephen Rothwell
2003-03-05 21:43 ` Pavel Machek
2003-03-04 23:36 ` Stephen Rothwell
2003-03-06 23:37 ` Pavel Machek [this message]
2003-03-09 22:44 ` Stephen Rothwell
2003-03-10 11:28 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030306233721.GA8565@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).