linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Linux 2.5.64-ac3
@ 2003-03-07 17:56 Alan Cox
  2003-03-07 20:14 ` [patch] 2.5.64-ac3: fix a typo in ide-default.c Adrian Bunk
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Alan Cox @ 2003-03-07 17:56 UTC (permalink / raw)
  To: linux-kernel

Handle with care...

Linux 2.5.64-ac3
o	Bring core IDE code into sync with the latest	(me)
	2.4.21pre5-ac code base. The drivers are not
	quite current with it yet.

Linux 2.5.64-ac2
o	Fix missing ; in w9966 (#310)			(Frank Davies)
o	Fix missing ; in whiteheat (#314)		(Frank Davies)
o	Fix missing ; in cs46xx (#317)			(Frank Davies)
o	Fix double logical operator in ite_gpio (#321)	(Frank Davies)
o	Fix double logical opeator in advansys (#324)	(me)
o	Fix aha1542 setup to allow full config by	(Hanna Linder)
	setup options (#242)
o	Fix /proc bug in via ide handlers (#374)	(Faik Uygur)
o	Add #error for the mwave race (#185)		(me)
	| Fixing it needs rather more thought
o	Fix apic compile problem			(Adriank Bunk)
o	Fix mremap slab corruption			(Hugh Dickins)
o	Fix sysfs mount permissions			(Patrick Mochel)
o	v850 updates					(Miles Bader)
o	Update all the parport layer to new module	(Bob Miller)
	API's remove check region misuse etc
o	Updated gdth driver from Intel			(Achim Leubner)
o	Small ALi ide setup fixes			(Ivan Kokshaysky)
	| Basically mirror those applied to 2.4 before the 1563
	| support was added
o	Add kerneldoc for user space access		(Jon Foster)
o	Fix incorrect unregister for cciss		(Herbert Xu)
o	cciss hotplug crash fix				(Stephen Cameron)
o	Fix error in 3c501 comments			(Steven Cole)
o	More c99 intialisers 				(Art Haas)
o	Updated mwave driver (still broken in part)	(Paul Schroeder,
							 Wes Schreiner)
o	Fdomain scsi cleanups, fix host list walk etc	(Christoph Hellwig)
o	Qlogic pcmcia scsi update			(Christoph Hellwig)
	| Still needs shared IRQ fix from 2.4.21pre5-ac
o	Fix bracketing error in maestro oss driver	(John Levon)
o	Don't claim too many ports for rtc		(Rusty Lynch)
o	Fix broken checks in i810_audio			(John Levon)
	| Still wants 2.4.21pre5-ac ac97/i810 fixes pulling
o	Fix e1000 hung zerop copy transfer on 82544
o	Add new board to cciss driver			(Stephen Cameron)
o	Fix piix build with CONFIG_PROC_FS=n		(Randy Dunlap)
o	Fix kmod SIGCLD problem				(Stelian Pop)
o	Fix check_region use in ht6560b			(Christoph Hellwig)
o	Fix check/requests in ide-dma			(Christoph Hellwig)
o	Remove dead __NO_VERSION__ from ide		(Christoph Hellwig)
o	Add PC9800 sound driver for CS4232		(Osamu Tomita)
o	Add per mach support for APM (for PC9800)	(Osamu Tomita)
o	PC9800 has different PnP locations to		(Osamu Tomita)
	normal
o	Handle NMI using mach-* scheme			(Osamu Tomita)
o	Fix /proc on slc90e66,sis5513, siimage, 	(Faik Uygur)
	serverworks, sc1200, piix, pdc202xx_old,
	pdc202xx_new, htp366, htp34x, cs5520, 
	amd74xx, aec62xx
o	IRQ stacks are back				(Dave Hansen)
o	Update 3c527 to modern locking (untested)	(James Bottomley)
o	PC9800 FAT handling				(Osamu Tomita)
o	PC9800 partition table handling	(Kyoto University Microcomputer Club)
o	CPIA updates/fixes				(Duncan Haldane)
o	IRDA timer fix					(Jean Tourrilhes)
o	Fix locking in irda discover code		(Jean Tourrilhes)
o	IrLap dynamic window fixes			(Jean Tourrilhes)
o	irda-usb cleanup and fixes			(Jean Tourrilhes)
o	Zerocopy rx for SIR				(Jean Tourrilhes)
o	Fix IrNET refcounting and discovery hints	(Jean Tourrilhes)
o	Fix kernel command line documentation		(Pavel Machek)
o	Fix incorrect __init in mpu401			(Daniel Ritz)
o	Remove unused LINUX_VERSION_CODE from sym53c416	(Adrian Bunk)
o	Fix check_region/request_region for ALSA isa	(Marcus Alanen)
	opti92x/ad1848
o	Update depca driver to eisa/sysfs		(Marc Zyngier)
o	Depca compile fix				(me)
o	Fix serial core stuff, remove obsolete		(me)
	baud changes
o	Fix jiffies wrap check code for 64bit		(Andi Kleen)
o	PCI quirk typo fix				(Geert Uytterhoeven)
o	Fix console initcall on Alpha			(Marc Zyngier)
o	Fix missing return value in pci irq changes	(Andrew Morton)
O	Fix usb-serial warnings with gcc 3.2		(David Gibson)
o	Fix warning in ohci on pwoerbook		(David Gibson)
o	IA64 needs syscall returns to be long		(David Mosberger)
o	S/390 updates					(Martin Schwidefsky)

Linux 2.5.64-ac1
	Merge Linus 2.5.63
	Merge Linus 2.5.64
	Revert broken watchdog changes
	Restore half removed make rpm
o	Revert wrong -ac change to keyboard.c		(me)
o	Fix cpufreq compile				(Bob Miller)
o	Remove incorrect keyboard patch (#407)

Linux 2.5.62-ac1
	Merge Linus 2.5.62
o	UNEXPECTED_IO_APIC can be static		(Pavel Machek)
o	Update IPMI driver to version 18		(Corey Minyard)
o	Tons of spelling fixes				(Steven Cole)
o	FBdev updates					(James Simmons)
o	PC-9800 update					(Osamu Tomita)
o	Remove dead scripts				(Brian Gerst)
o	v850 updates					(Miles Bader)
o	Update 3c523 to new MCA api (untested)		(James Bottomley)
o	Toshiba keyboard workaround			(Pavel Machek)
o	Fix mremap file name in comments		(Paul Larson)
o	Firestream typo fixes				(Maciej Soltysiak)
o	Backport trident reset fix from 2.4		(Muli Ben-Yehuda)
o	Morse code panics are back!			(Tomas Szepe)
o	Fix aicasm build				(Bob Tracy)
o	Fixes for 700/710 drivers			(Rolf Eike Beer)
o	Spelling fixes					(Rolf Eike Beer)
o	Optimise CRC32					(Joakim Tjernlund)
o	Next batch of v850 updates			(Miles Bader)
o	Takayoshi Kochi has moved email			(Takayoshi Kochi)
o	SunRPC race fix					(Trond Myklebust)
o	Refix addr/port naming confusion in IDE iops	(me)
o	Forward port VIA APIC handling quirks		(me)
o	Forward port ALi magick quirk flag handler	(me)
	| Needs bt848 etc to acquire the fix too
o	Forward port IDE bases fix			(me)
o	Forward port pci irq search for legacy IDE	(me)

Linux 2.5.61-ac1
	Merge Linus 2.5.61
o	Fix aic7xxx makefile				(Sam Ravnborg)
o	Fix ieee1394 build on Alpha			(Ben Collins)
o	Fix isdn_net build with X.25			(Adriank Bunk)
o	Typo fix					(Steven Bosscher)
o	A pile of other typo fixes			(Steven Cole)
o	C99 initializers				(Art Haas)
o	dasd typo fix					(Maciej Soltysiak)
o	Remove an unused variable in sunrpc		(Robert Love)
o	Remove duplicate different BSD partition names	(Andries Brouwer)
o	PPC plural fix					(Steven Cole)
o	EISA driver class patches			(Marc Zyngier)
o	VIA Rhine updates				(Roger Luethi)
o	Further ppa scsi fix				(John Kim)
o	Kill unused __beep				(Hugh Dickins)
o	Merge visws support 				(Andrey Panin)
	| Some collisions with pc9800 but should be ok
o	Limits for upward growing stacks		(Matthew Wilcox)
o	ucLinux updates					(Greg Ungerer)
o	68328 frame buffer updates			(Greg Ungerer)
o	Merge ucLinux H8300 support			(Yoshinori Sato)
o	Fix aironet compile				(Ookhoi)
o	Fix DMA mask on OSS trident driver		(Ivan Kokshaysky)
o	Kill some old 2.4 glue code in DRM		(John Kim)
o	Fix compile of old "hd.c" driver		(Paul Gortmaker)
o	Add experimental BOCHS virtualisation		(Kevin Lawton)
o	Clean up intermezzo driver			(Adrian Bunk)
o	Clean up rio use of compatmac			(Adrian Bunk)
o	Remove 2.0 ifdefs from ipchains code		(Adrian Bunk)
o	Remove old junk from efs 			(Adrian Bunk)
o	Remove old 2.0/2.2 junk from media/video	(Adrian Bunk)
o	Remove unused variable in ali-ircc		(Adrian Bunk)
o	Remove 2.0 ifdefs from network drivers		(Adrian Bunk)
o	Clean up uglies in inia100			(Adrian Bunk)
o	Clean up uglies in i91u scsi 			(Adrian Bunk)
o	Clean up wan drivers 2.0/2.2 code		(Adrian Bunk)
o	Restore ontrack remap support			(Jim Houston)
	| I'd really like to see this get turned into device mapper..
o	Forward port emu10k1 driver to 2.5		(Rui Souza)
o	Fix boot on EPOX 4BEA-R and friends		(Alexandar Achenbach)
o	Switch alpha cia code to static inline		(Matt Reppert)
o	Fix pcmcia scsi compile breakages		(Mike Anderson)
o	EHCI workarounds				(David Brownell)

Linux 2.5.60-ac1 (not published)
	Includes Linus BK snapshot
	Merge relevant pieces from old -ac		(me)
	| Dropped visws and stuff thats been redone
	| also dropped out IRQ stacks (port is tricky!)
o	Fix build of cciss driver			(me)
o	Fix build of 3036 tv tuner			(me)
o	Remove i2o_lan					(me)
o	Fix i2o_scsi					(Randy Dunlap)
o	Fix iph5526 scsi changes (not fixed DMA)	(me)
o	Make starfire compile				(me)
o	Make mca-legacy warn if used			(me)
o	Make sim710 build with EISA			(me)
o	Make ultrastor compile				(me)
o	Make aha152x/aha154x build			(Randy Dunlap)
o	Fix aha154x/mca bits				(me)
o	Fix fd_mcs build				(me)
o	Fix NCR53c406a.c				(me)
o	Fix sym53c416.c					(me)
o	Fix ibmmca compile				(me)
o	Fix ppa compile					(me)
o	Fix NCR539x compile				(John Kim)
o	Fix mca_53c9x compile				(me)

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [patch] 2.5.64-ac3: fix a typo in ide-default.c
  2003-03-07 17:56 Linux 2.5.64-ac3 Alan Cox
@ 2003-03-07 20:14 ` Adrian Bunk
  2003-03-07 20:33 ` [PATCH][TRIVIAL] Re: Linux 2.5.64-ac3 Maciej Soltysiak
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 10+ messages in thread
From: Adrian Bunk @ 2003-03-07 20:14 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-kernel

The following patch fixes a typo in ide-default.c that causes a compile 
error:

--- linux-2.5.64-ac3/drivers/ide/ide-default.c.old	2003-03-07 21:11:35.000000000 +0100
+++ linux-2.5.64-ac3/drivers/ide/ide-default.c	2003-03-07 21:12:17.000000000 +0100
@@ -51,7 +51,7 @@
 	.name		=	"ide-default",
 	.version	=	IDEDEFAULT_VERSION,
 	.attach		=	idedefault_attach,
-	.supports_dma	=	1.
+	.supports_dma	=	1,
 	.drives		=	LIST_HEAD_INIT(idedefault_driver.drives)
 };
 


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH][TRIVIAL] Re: Linux 2.5.64-ac3
  2003-03-07 17:56 Linux 2.5.64-ac3 Alan Cox
  2003-03-07 20:14 ` [patch] 2.5.64-ac3: fix a typo in ide-default.c Adrian Bunk
@ 2003-03-07 20:33 ` Maciej Soltysiak
  2003-03-07 23:08   ` Alan Cox
  2003-03-07 21:03 ` 2.5.64-ac3: 3c527.c doesn't compile Adrian Bunk
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Maciej Soltysiak @ 2003-03-07 20:33 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 596 bytes --]

Hi,

> Linux 2.5.64-ac3
> o	Bring core IDE code into sync with the latest	(me)
> 	2.4.21pre5-ac code base. The drivers are not
> 	quite current with it yet.
There's a typo that breaks compiling ide-default.c

Here's the patch:

--- linux-2.5.60/drivers/ide/ide-default.c~	2003-03-07 20:32:32.000000000 +0100
+++ linux-2.5.60/drivers/ide/ide-default.c	2003-03-07 21:30:01.000000000 +0100
@@ -51,7 +51,7 @@
 	.name		=	"ide-default",
 	.version	=	IDEDEFAULT_VERSION,
 	.attach		=	idedefault_attach,
-	.supports_dma	=	1.
+	.supports_dma	=	1,
 	.drives		=	LIST_HEAD_INIT(idedefault_driver.drives)
 };

[-- Attachment #2: ide-default.c.diff --]
[-- Type: TEXT/plain, Size: 381 bytes --]

--- linux-2.5.60/drivers/ide/ide-default.c~	2003-03-07 20:32:32.000000000 +0100
+++ linux-2.5.60/drivers/ide/ide-default.c	2003-03-07 21:30:01.000000000 +0100
@@ -51,7 +51,7 @@
 	.name		=	"ide-default",
 	.version	=	IDEDEFAULT_VERSION,
 	.attach		=	idedefault_attach,
-	.supports_dma	=	1.
+	.supports_dma	=	1,
 	.drives		=	LIST_HEAD_INIT(idedefault_driver.drives)
 };
 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* 2.5.64-ac3: 3c527.c doesn't compile
  2003-03-07 17:56 Linux 2.5.64-ac3 Alan Cox
  2003-03-07 20:14 ` [patch] 2.5.64-ac3: fix a typo in ide-default.c Adrian Bunk
  2003-03-07 20:33 ` [PATCH][TRIVIAL] Re: Linux 2.5.64-ac3 Maciej Soltysiak
@ 2003-03-07 21:03 ` Adrian Bunk
  2003-03-07 21:34   ` James Bottomley
  2003-03-09  1:58 ` Question about VISWS 2.5.64-ac3 Osamu Tomita
  2003-03-09  2:16 ` New IDE codes in 2.5.64-ac3 Osamu Tomita
  4 siblings, 1 reply; 10+ messages in thread
From: Adrian Bunk @ 2003-03-07 21:03 UTC (permalink / raw)
  To: Alan Cox, James Bottomley; +Cc: linux-kernel

On Fri, Mar 07, 2003 at 12:56:44PM -0500, Alan Cox wrote:

>...
> Linux 2.5.64-ac2
>...
> o	Update 3c527 to modern locking (untested)	(James Bottomley)
>...

It seems even the compilation is untested?

<--  snip  -->

...
  gcc -Wp,-MD,drivers/net/.3c527.o.d -D__KERNEL__ -Iinclude -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-pipe -mpreferred-stack-boundary=2 -march=k6 
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include    
-DKBUILD_BASENAME=3c527 -DKBUILD_MODNAME=3c527 -c -o drivers/net/3c527.o 
drivers/net/3c527.c
In file included from include/linux/mca.h:132,
                 from drivers/net/3c527.c:95:
include/linux/mca-legacy.h:10: warning: #warning "MCA legacy - please 
move your driver to the new sysfs api"
drivers/net/3c527.c: In function `mc32_command':
drivers/net/3c527.c:649: `flags' undeclared (first use in this function)
drivers/net/3c527.c:649: (Each undeclared identifier is reported only once
drivers/net/3c527.c:649: for each function it appears in.)
drivers/net/3c527.c: In function `mc32_halt_transceiver':
drivers/net/3c527.c:733: `flags' undeclared (first use in this function)
drivers/net/3c527.c: In function `mc32_open':
drivers/net/3c527.c:951: `unsigned_long' undeclared (first use in this function)
drivers/net/3c527.c:951: parse error before `flags'
drivers/net/3c527.c:953: `flags' undeclared (first use in this function)
make[2]: *** [drivers/net/3c527.o] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 2.5.64-ac3: 3c527.c doesn't compile
  2003-03-07 21:03 ` 2.5.64-ac3: 3c527.c doesn't compile Adrian Bunk
@ 2003-03-07 21:34   ` James Bottomley
  2003-03-22  8:23     ` Adrian Bunk
  0 siblings, 1 reply; 10+ messages in thread
From: James Bottomley @ 2003-03-07 21:34 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Alan Cox, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

On Fri, 2003-03-07 at 15:03, Adrian Bunk wrote:
> On Fri, Mar 07, 2003 at 12:56:44PM -0500, Alan Cox wrote:
> 
> >...
> > Linux 2.5.64-ac2
> >...
> > o	Update 3c527 to modern locking (untested)	(James Bottomley)
> >...
> 
> It seems even the compilation is untested?

It builds for me fine in 2.5.64.  Perhaps you misapplied the patch, or
got a mangled one.  The correct patch is below.

James


[-- Attachment #2: tmp.diff --]
[-- Type: application/octet-stream, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH][TRIVIAL] Re: Linux 2.5.64-ac3
  2003-03-07 20:33 ` [PATCH][TRIVIAL] Re: Linux 2.5.64-ac3 Maciej Soltysiak
@ 2003-03-07 23:08   ` Alan Cox
  0 siblings, 0 replies; 10+ messages in thread
From: Alan Cox @ 2003-03-07 23:08 UTC (permalink / raw)
  To: Maciej Soltysiak; +Cc: Alan Cox, Linux Kernel Mailing List

On Fri, 2003-03-07 at 20:33, Maciej Soltysiak wrote:
> Hi,
> 
> > Linux 2.5.64-ac3
> > o	Bring core IDE code into sync with the latest	(me)
> > 	2.4.21pre5-ac code base. The drivers are not
> > 	quite current with it yet.
> There's a typo that breaks compiling ide-default.c
> 
> Here's the patch:
> 
> --- linux-2.5.60/drivers/ide/ide-default.c~	2003-03-07 20:32:32.000000000 +0100
> +++ linux-2.5.60/drivers/ide/ide-default.c	2003-03-07 21:30:01.000000000 +0100
> @@ -51,7 +51,7 @@
>  	.name		=	"ide-default",
>  	.version	=	IDEDEFAULT_VERSION,
>  	.attach		=	idedefault_attach,
> -	.supports_dma	=	1.
> +	.supports_dma	=	1,
>  	.drives		=	LIST_HEAD_INIT(idedefault_driver.drives)
>  };

Thanks. Last minute conversion to C99 format to avoid flames 8)



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Question about VISWS 2.5.64-ac3
  2003-03-07 17:56 Linux 2.5.64-ac3 Alan Cox
                   ` (2 preceding siblings ...)
  2003-03-07 21:03 ` 2.5.64-ac3: 3c527.c doesn't compile Adrian Bunk
@ 2003-03-09  1:58 ` Osamu Tomita
  2003-03-09  2:16 ` New IDE codes in 2.5.64-ac3 Osamu Tomita
  4 siblings, 0 replies; 10+ messages in thread
From: Osamu Tomita @ 2003-03-09  1:58 UTC (permalink / raw)
  To: Alan Cox; +Cc: Linux Kernel Mailing List

2.5.64-ac might need patch for VISWS below?
I'm not sure. Because I don't know about VISWS.
Please check.

Regards,
Osamu Tomita

diff -Nru linux-2.5.64-ac3/arch/i386/mach-visws/visws_apic.c linux/arch/i386/mach-visws/visws_apic.c
--- linux-2.5.64-ac3/arch/i386/mach-visws/visws_apic.c	2003-03-08 13:54:20.000000000 +0900
+++ linux/arch/i386/mach-visws/visws_apic.c	2003-03-08 14:49:53.000000000 +0900
@@ -230,12 +230,12 @@
 	cached_irq_mask |= 1 << realirq;
 	if (unlikely(realirq > 7)) {
 		inb(0xa1);
-		outb(cached_A1, 0xa1);
+		outb(cached_slave_mask, 0xa1);
 		outb(0x60 + (realirq & 7), 0xa0);
 		outb(0x60 + 2, 0x20);
 	} else {
 		inb(0x21);
-		outb(cached_21, 0x21);
+		outb(cached_master_mask, 0x21);
 		outb(0x60 + realirq, 0x20);
 	}
 
diff -Nru linux-2.5.64-ac3/include/asm-i386/mach-visws/irq_vectors.h linux/include/asm-i386/mach-visws/irq_vectors.h
--- linux-2.5.64-ac3/include/asm-i386/mach-visws/irq_vectors.h	2003-03-08 13:54:58.000000000 +0900
+++ linux/include/asm-i386/mach-visws/irq_vectors.h	2003-03-08 14:08:33.000000000 +0900
@@ -51,4 +51,10 @@
  */
 #define NR_IRQS 224
 
+#define FPU_IRQ			13
+
+#define	FIRST_VM86_IRQ		3
+#define LAST_VM86_IRQ		15
+#define invalid_vm86_irq(irq)	((irq) < 3 || (irq) > 15)
+
 #endif /* _ASM_IRQ_VECTORS_H */

^ permalink raw reply	[flat|nested] 10+ messages in thread

* New IDE codes in 2.5.64-ac3
  2003-03-07 17:56 Linux 2.5.64-ac3 Alan Cox
                   ` (3 preceding siblings ...)
  2003-03-09  1:58 ` Question about VISWS 2.5.64-ac3 Osamu Tomita
@ 2003-03-09  2:16 ` Osamu Tomita
  2003-03-09 20:53   ` Alan Cox
  4 siblings, 1 reply; 10+ messages in thread
From: Osamu Tomita @ 2003-03-09  2:16 UTC (permalink / raw)
  To: Alan Cox; +Cc: Linux Kernel Mailing List

My PC98 box doesn't boot 2.5.64-ac3.
After print "ide-default: hdd: Failed to register the driver with ide.c"
forced to panic.
"hdd" is not connected my box.
IMHO We need status meaning 'supported by the driver but drive not present'.
Or this problem is PC98 specific?
I attached my quick fix. Please comment.

Regards,
Osamu Tomita

diff -Nru linux-2.5.64-ac3/drivers/ide/ide-default.c linux-2.5.64-ac3-quick-fix/drivers/ide/ide-default.c
--- linux-2.5.64-ac3/drivers/ide/ide-default.c	2003-03-08 12:51:33.000000000 +0900
+++ linux-2.5.64-ac3-quick-fix/drivers/ide/ide-default.c	2003-03-09 10:14:51.000000000 +0900
@@ -61,7 +61,8 @@
 			&idedefault_driver, IDE_SUBDRIVER_VERSION)) {
 		printk(KERN_ERR "ide-default: %s: Failed to register the "
 			"driver with ide.c\n", drive->name);
-		return 1;
+		//return 1;
+		drive->present = 0;
 	}
 	return 0;
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New IDE codes in 2.5.64-ac3
  2003-03-09  2:16 ` New IDE codes in 2.5.64-ac3 Osamu Tomita
@ 2003-03-09 20:53   ` Alan Cox
  0 siblings, 0 replies; 10+ messages in thread
From: Alan Cox @ 2003-03-09 20:53 UTC (permalink / raw)
  To: Osamu Tomita; +Cc: Alan Cox, Linux Kernel Mailing List

On Sun, 2003-03-09 at 02:16, Osamu Tomita wrote:
> My PC98 box doesn't boot 2.5.64-ac3.
> After print "ide-default: hdd: Failed to register the driver with ide.c"
> forced to panic.
> "hdd" is not connected my box.
> IMHO We need status meaning 'supported by the driver but drive not present'.
> Or this problem is PC98 specific?

Every device registered should now have a driver in all situations. The 
panic sounds like the pc98 ide might be using ata_attach() directly or
indirectly on a non existant disk. That would upset things


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 2.5.64-ac3: 3c527.c doesn't compile
  2003-03-07 21:34   ` James Bottomley
@ 2003-03-22  8:23     ` Adrian Bunk
  0 siblings, 0 replies; 10+ messages in thread
From: Adrian Bunk @ 2003-03-22  8:23 UTC (permalink / raw)
  To: James Bottomley; +Cc: Alan Cox, linux-kernel

On Fri, Mar 07, 2003 at 03:34:52PM -0600, James Bottomley wrote:
> On Fri, 2003-03-07 at 15:03, Adrian Bunk wrote:
> > On Fri, Mar 07, 2003 at 12:56:44PM -0500, Alan Cox wrote:
> > 
> > >...
> > > Linux 2.5.64-ac2
> > >...
> > > o	Update 3c527 to modern locking (untested)	(James Bottomley)
> > >...
> > 
> > It seems even the compilation is untested?
> 
> It builds for me fine in 2.5.64.  Perhaps you misapplied the patch, or
> got a mangled one.  The correct patch is below.

The patch in your mail was empty.

The problem is still present in 2.5.65-ac2, is the patch below correct?

> James

cu
Adrian

--- linux-2.5.65-ac2/drivers/net/3c527.c.old	2003-03-22 09:19:39.000000000 +0100
+++ linux-2.5.65-ac2/drivers/net/3c527.c	2003-03-22 09:20:44.000000000 +0100
@@ -624,7 +624,8 @@
 	struct mc32_local *lp = (struct mc32_local *)dev->priv;
 	int ioaddr = dev->base_addr;
 	int ret = 0;
-	
+	unsigned long flags;
+
 	/*
 	 *	Wait for a command
 	 */
@@ -729,6 +730,7 @@
 {
 	struct mc32_local *lp = (struct mc32_local *)dev->priv;
 	int ioaddr = dev->base_addr;
+	unsigned long flags;
 
 	spin_lock_irqsave(&lp->lock, flags);
 
@@ -948,7 +950,7 @@
 	u8 one=1;
 	u8 regs;
 	u16 descnumbuffs[2] = {TX_RING_LEN, RX_RING_LEN};
-	unsigned_long flags;
+	unsigned long flags;
 
 	spin_lock_irqsave(&lp->lock, flags);
 

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2003-03-22  8:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-07 17:56 Linux 2.5.64-ac3 Alan Cox
2003-03-07 20:14 ` [patch] 2.5.64-ac3: fix a typo in ide-default.c Adrian Bunk
2003-03-07 20:33 ` [PATCH][TRIVIAL] Re: Linux 2.5.64-ac3 Maciej Soltysiak
2003-03-07 23:08   ` Alan Cox
2003-03-07 21:03 ` 2.5.64-ac3: 3c527.c doesn't compile Adrian Bunk
2003-03-07 21:34   ` James Bottomley
2003-03-22  8:23     ` Adrian Bunk
2003-03-09  1:58 ` Question about VISWS 2.5.64-ac3 Osamu Tomita
2003-03-09  2:16 ` New IDE codes in 2.5.64-ac3 Osamu Tomita
2003-03-09 20:53   ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).