From: Andrew Morton <akpm@digeo.com>
To: Anders Gustafsson <andersg@0x63.nu>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix big initramfs (was: [PATCH] gen_init_cpio fixes for 2.5.64)
Date: Wed, 12 Mar 2003 00:48:01 -0800 [thread overview]
Message-ID: <20030312004801.527dfdf1.akpm@digeo.com> (raw)
In-Reply-To: <20030312082203.GA22432@h55p111.delphi.afb.lu.se>
Anders Gustafsson <andersg@0x63.nu> wrote:
>
> Patch below makes the call to page_writeback_init() explicit in
> start_kernel, just before populate_rootfs().
>
Fair enough.
> +extern void page_writeback_init(void);
But please don't put declarations of external functions into .c. It is
always the wrong thing to do, even though others have done it...
writeback.h is a fine place for this declaration.
next prev parent reply other threads:[~2003-03-12 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-05 6:08 [BK PATCH] klibc for 2.5.64 Greg KH
2003-03-08 0:42 ` [BK PATCH] gen_init_cpio fixes " Greg KH
2003-03-08 0:43 ` [PATCH] " Greg KH
2003-03-08 0:44 ` Greg KH
2003-03-08 14:37 ` Anders Gustafsson
2003-03-09 6:04 ` Greg KH
2003-03-09 21:28 ` Anders Gustafsson
2003-03-12 8:22 ` [PATCH] fix big initramfs (was: [PATCH] gen_init_cpio fixes for 2.5.64) Anders Gustafsson
2003-03-12 8:48 ` Andrew Morton [this message]
2003-03-12 9:25 ` Anders Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030312004801.527dfdf1.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=andersg@0x63.nu \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).