linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: "Dimitry V. Ketov" <Dimitry.Ketov@avalon.ru>
Cc: netdev@oss.sgi.com, "" <linux-kernel@vger.kernel.org>,
	"" <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH] [2.4.20] filter_list destroy fix in net/sched/sch_prio.c
Date: Thu, 10 Apr 2003 13:57:46 -0400 (EDT)	[thread overview]
Message-ID: <20030410135727.M86925@shell.cyberus.ca> (raw)
In-Reply-To: <E1B7C89B8DCB084C809A22D7FEB90B381773AD@frodo.avalon.ru>



Looks good to me.

cheers,
jamal

On Thu, 10 Apr 2003, Dimitry V. Ketov wrote:

> The prio qdisc does not destroy its filter list, when someone deletes
> qdisc from interface without explicit filter deleting.
> This patch fixes that behavior.
>
> --- linux-2.4.20/net/sched/sch_prio.c	Sat Aug  3 04:39:46 2002
> +++ linux/net/sched/sch_prio.c	Thu Apr 10 17:52:55 2003
> @@ -158,11 +158,19 @@
>  {
>  	int prio;
>  	struct prio_sched_data *q = (struct prio_sched_data *)sch->data;
> +	struct tcf_proto *tp;
>
>  	for (prio=0; prio<q->bands; prio++) {
>  		qdisc_destroy(q->queues[prio]);
>  		q->queues[prio] = &noop_qdisc;
>  	}
> +
> +	while((tp = q->filter_list) != NULL)
> +	{
> +		q->filter_list = tp->next;
> +		tp->ops->destroy(tp);
> +	}
> +
>  	MOD_DEC_USE_COUNT;
>  }
>
>
>
>

  reply	other threads:[~2003-04-10 18:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-10 17:46 [PATCH] [2.4.20] filter_list destroy fix in net/sched/sch_prio.c Dimitry V. Ketov
2003-04-10 17:57 ` jamal [this message]
2003-04-12  7:32   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030410135727.M86925@shell.cyberus.ca \
    --to=hadi@cyberus.ca \
    --cc=Dimitry.Ketov@avalon.ru \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).