From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264327AbTDPMRE (for ); Wed, 16 Apr 2003 08:17:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264329AbTDPMRE (for ); Wed, 16 Apr 2003 08:17:04 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:41742 "EHLO atrey.karlin.mff.cuni.cz") by vger.kernel.org with ESMTP id S264327AbTDPMRE (for ); Wed, 16 Apr 2003 08:17:04 -0400 Date: Wed, 16 Apr 2003 14:28:56 +0200 From: Jan Kara To: Pavel Roskin Cc: linux-kernel@vger.kernel.org, Alan Cox Subject: Re: [TRIVIAL PATCH] sync_dquots_dev in Linux 2.4.21-pre7-ac1 Message-ID: <20030416122856.GA21806@atrey.karlin.mff.cuni.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > sync_dquots_dev() is only implemented if CONFIG_QUOTA is defined. > However, quote.c uses it unconditionally. include/linux/quotaops.h has > some macros to disable some functions when CONFIG_QUOTA is undefined, so > it's probably where the fix belongs. This patch helps: > > ============================== > --- linux.orig/include/linux/quotaops.h > +++ linux/include/linux/quotaops.h > @@ -193,6 +193,7 @@ > #define DQUOT_SYNC_SB(sb) do { } while(0) > #define DQUOT_OFF(sb) do { } while(0) > #define DQUOT_TRANSFER(inode, iattr) (0) > +#define sync_dquots_dev(dev, type) do { } while(0) > extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr) > { > lock_kernel(); > ============================== Oops... Yes. Please apply the patch Alan. Thanks Honza -- Jan Kara SuSE CR Labs