linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-kernel@vger.kernel.org, andre@linux-ide.org
Subject: Re: 2.5.68-bk1 renames IDE disks, /dev/hda is directory
Date: Mon, 21 Apr 2003 18:39:35 +0200	[thread overview]
Message-ID: <20030421183935.A27811@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.55.0304211157430.14766@marabou.research.att.com>; from proski@gnu.org on Mon, Apr 21, 2003 at 12:08:11PM -0400

On Mon, Apr 21, 2003 at 12:08:11PM -0400, Pavel Roskin wrote:
> Hello!
> 
> After upgrading from 2.5.67-bk9 to 2.5.68-bk1 I have found that the devfs
> names for IDE disks have changed.  Instead of the traditional
> 2.4-compatible /dev/ide/host0/bus0/target0/lun0/part1, /dev/hda1 has now
> become /dev/hda/disc0/part1.
> 
> What's really weird is that /dev/hda is now a directory.  That's going to
> break a lot of software!

Hey, that wasn't intentation.  In fact it's a stupid brown-paperbag bug
only hidden by mount-by-label :)

Here's the fix:


--- 1.1/fs/partitions/devfs.c	Sat Apr 19 20:57:36 2003
+++ edited/fs/partitions/devfs.c	Mon Apr 21 17:11:33 2003
@@ -81,7 +81,7 @@
 {
 	char dirname[64], symlink[16];
 
-	if (disk->devfs_name[0] != '\0')
+	if (disk->devfs_name[0] == '\0')
 		sprintf(disk->devfs_name, "%s/disc%d", disk->disk_name,
 				disk->first_minor >> disk->minor_shift);
 

  reply	other threads:[~2003-04-21 16:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-21 16:08 2.5.68-bk1 renames IDE disks, /dev/hda is directory Pavel Roskin
2003-04-21 16:39 ` Christoph Hellwig [this message]
2003-04-21 16:55   ` Pavel Roskin
2003-04-24 17:01   ` Pavel Roskin
2003-04-24 17:04     ` Christoph Hellwig
2003-04-24 17:56       ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030421183935.A27811@lst.de \
    --to=hch@lst.de \
    --cc=andre@linux-ide.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).