* [PATCH] USB speedtouch: crc optimization
@ 2003-04-23 8:50 Duncan Sands
2003-04-23 19:34 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Duncan Sands @ 2003-04-23 8:50 UTC (permalink / raw)
To: linux-usb-devel; +Cc: Greg KH, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
speedtch.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
+++ b/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
@@ -406,11 +406,12 @@
** encode **
*************/
+static const unsigned char zeros[ATM_CELL_PAYLOAD];
+
static void udsl_groom_skb (struct atm_vcc *vcc, struct sk_buff *skb)
{
struct udsl_control *ctrl = UDSL_SKB (skb);
- unsigned int i, zero_padding;
- unsigned char zero = 0;
+ unsigned int zero_padding;
u32 crc;
ctrl->atm_data.vcc = vcc;
@@ -436,8 +437,7 @@
ctrl->aal5_trailer [3] = skb->len;
crc = crc32_be (~0, skb->data, skb->len);
- for (i = 0; i < zero_padding; i++)
- crc = crc32_be (crc, &zero, 1);
+ crc = crc32_be (crc, zeros, zero_padding);
crc = crc32_be (crc, ctrl->aal5_trailer, 4);
crc = ~crc;
[-- Attachment #2: send-2.4.diff --]
[-- Type: text/x-diff, Size: 901 bytes --]
speedtouch.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/speedtouch.c b/drivers/usb/speedtouch.c
--- a/drivers/usb/speedtouch.c Wed Apr 23 10:48:28 2003
+++ b/drivers/usb/speedtouch.c Wed Apr 23 10:48:28 2003
@@ -406,11 +406,12 @@
** encode **
*************/
+static const unsigned char zeros[ATM_CELL_PAYLOAD];
+
static void udsl_groom_skb (struct atm_vcc *vcc, struct sk_buff *skb)
{
struct udsl_control *ctrl = UDSL_SKB (skb);
- unsigned int i, zero_padding;
- unsigned char zero = 0;
+ unsigned int zero_padding;
u32 crc;
ctrl->atm_data.vcc = vcc;
@@ -436,8 +437,7 @@
ctrl->aal5_trailer [3] = skb->len;
crc = crc32_be (~0, skb->data, skb->len);
- for (i = 0; i < zero_padding; i++)
- crc = crc32_be (crc, &zero, 1);
+ crc = crc32_be (crc, zeros, zero_padding);
crc = crc32_be (crc, ctrl->aal5_trailer, 4);
crc = ~crc;
[-- Attachment #3: send-2.5.diff --]
[-- Type: text/x-diff, Size: 911 bytes --]
speedtch.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
+++ b/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
@@ -406,11 +406,12 @@
** encode **
*************/
+static const unsigned char zeros[ATM_CELL_PAYLOAD];
+
static void udsl_groom_skb (struct atm_vcc *vcc, struct sk_buff *skb)
{
struct udsl_control *ctrl = UDSL_SKB (skb);
- unsigned int i, zero_padding;
- unsigned char zero = 0;
+ unsigned int zero_padding;
u32 crc;
ctrl->atm_data.vcc = vcc;
@@ -436,8 +437,7 @@
ctrl->aal5_trailer [3] = skb->len;
crc = crc32_be (~0, skb->data, skb->len);
- for (i = 0; i < zero_padding; i++)
- crc = crc32_be (crc, &zero, 1);
+ crc = crc32_be (crc, zeros, zero_padding);
crc = crc32_be (crc, ctrl->aal5_trailer, 4);
crc = ~crc;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-23 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-23 8:50 [PATCH] USB speedtouch: crc optimization Duncan Sands
2003-04-23 19:34 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).